[new feature] Article notes field #19134

brianteeman · 2017-12-22T12:24:10Z

We have a note field for com_categories, com_menus and com_modules
This PR adds the functionality to com_content as it has been requested several times and can be very useful

To test

Apply the pr AND the database fix (we added a new field)
Create an article and on the right, above version note you will see a new field called note
Enter a note and save the article
You can now see the note with the article in the list
You can also search by the note
Check the featured article list
Check the article modal list (article xtd-editor button or from creating a new single article menu)

On the frontend you can also add/edit a note. You will see it on the publishing tab above the version note field

Bonus

When adding this field to the frontend beez template I spotted that the version note field wasnt shown there either so I added that at the same time

We have a note field for com_categories, com_menus and com_modules This PR adds the functionality to com_content as it has been requested several times and can be very useful ## To test Apply the pr AND the database fix (we added a new field) Create an article and on the right above version note you will see a new field called note Enter a note and save the article You can now see the note with the article You can also search by the note Check the featured article list Check the article modal list (article xtd-editor button or from creating a new single article menu) On the frontend you can also add/edit a note. You will see it on the publishing tab above the version note field

csthomas · 2017-12-22T12:36:05Z

administrator/components/com_admin/sql/updates/postgresql/3.9.0-2017-12-22.sql

@@ -0,0 +1,4 @@
+ALTER TABLE `#__content` ADD COLUMN `note` VARCHAR(255) NOT NULL DEFAULT '';
+


Use '"' (double quote) instead '`' to escape names in postgresql.

thanks - should be ok now

Quy · 2017-12-22T17:24:35Z

administrator/components/com_content/views/articles/tmpl/modal.php

@@ -138,6 +138,13 @@
 							<a class="select-link" href="javascript:void(0)" <?php echo $attribs; ?>>
 								<?php echo $this->escape($item->title); ?>
 							</a>
+							<span class="small" title="<?php echo $this->escape($item->path); ?>">


Same fix here with the underlined space.

PHP Notice: Undefined property: stdClass::$path in\administrator\components\com_content\views\articles\tmpl\modal.php on line 141

Quy · 2017-12-22T17:33:18Z

administrator/components/com_content/models/forms/article.xml

+			type="text"
+			label="COM_CONTENT_FIELD_NOTE_LABEL"
+			description="COM_CONTENT_FIELD_NOTE_DESC"
+			class="span12"


change to inputbox

Please check the other notes fields in modules and menu. I am sure this si the same

Quy · 2017-12-22T18:49:30Z

templates/beez3/html/com_content/form/edit.php

+				</div>
+				<div class="controls">
+					<?php echo $this->form->getInput('version_note'); ?>
+				</div			


Add closing >

Quy · 2017-12-22T19:39:37Z

On the frontend, the note field is wider due to the span12 class.

Quy · 2017-12-22T20:36:09Z

administrator/components/com_content/views/articles/tmpl/modal.php

-								<?php echo $this->escape($item->title); ?>
-							</a>
+								<?php echo $this->escape($item->title); ?></a>
+							<span class="small">


Add break-word?

might as well - wont do any harm

Quy · 2017-12-23T06:22:56Z

I have tested this item ✅ successfully on c78fdf4

Tested with MySQL

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19134.}

alikon

the update is wrong you need a single quote before the
{"common..... and another one at the end fulltext"}}

should be something like
'{"common":{"core_content_item_id":"id","core_title":"title","core_state":"state","core_alias":"alias","core_created_time":"created","core_modified_time":"modified","core_body":"introtext", "core_hits":"hits","core_publish_up":"publish_up","core_publish_down":"publish_down","core_access":"access", "core_params":"attribs", "core_featured":"featured", "core_metadata":"metadata", "core_language":"language", "core_images":"images", "core_urls":"urls", "core_version":"version", "core_ordering":"ordering", "core_metakey":"metakey", "core_metadesc":"metadesc", "core_catid":"catid", "core_xreference":"xreference", "asset_id":"asset_id", "note":"note"}, "special":{"fulltext":"fulltext"}}'

the same fix on postgresql and mssql

brianteeman · 2017-12-23T10:02:26Z

@alikon all done - thanks

alikon · 2017-12-24T08:45:04Z

I have tested this item ✅ successfully on e67b603

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19134.}

ghost · 2017-12-24T09:31:59Z

@Quy can you please retest?

Quy · 2017-12-24T15:55:54Z

I have tested this item ✅ successfully on e67b603

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19134.}

Quy · 2017-12-24T17:10:57Z

RTC

Quy · 2018-05-29T17:05:59Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19134.}

brianteeman · 2018-06-02T17:46:50Z

Thanks

brianteeman added 3 commits December 22, 2017 11:49

beez

ecc1221

sql

b164cf4

joomla-cms-bot added Language Change This is for Translators PR-staging labels Dec 22, 2017

This was referenced Dec 22, 2017

Notes for articles feature request #18422

Closed

Add note field to article #16180

Closed

codestyle

8a34919

csthomas reviewed Dec 22, 2017

View reviewed changes

quotes

15c48e1

brianteeman added this to the Joomla 3.9.0 milestone Dec 22, 2017

Quy reviewed Dec 22, 2017

View reviewed changes

brianteeman added 3 commits December 22, 2017 17:44

modal fix

699a436

modal fix (reverted from commit 699a436)

f3d710f

modal fix

a1279ad

Quy reviewed Dec 22, 2017

View reviewed changes

beez

852d8a5

frontend width

8e40297

Quy reviewed Dec 22, 2017

View reviewed changes

breakword

c78fdf4

alikon suggested changes Dec 23, 2017

View reviewed changes

update sql fixes as requested by @alikon

e67b603

alikon approved these changes Dec 24, 2017

View reviewed changes

Quy mentioned this pull request Dec 24, 2017

[ChangeItem] - the check query should return array instead of object - PHP 7.2 #18443

Merged

joomla-cms-bot removed this from the Joomla 3.9.0 milestone Dec 24, 2017

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 24, 2017

infograf768 added this to the Joomla 3.9.0 milestone Dec 28, 2017

brianteeman closed this Apr 3, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 3, 2018

zero-24 removed this from the Joomla 3.9.0 milestone Apr 7, 2018

brianteeman deleted the article-notes branch May 29, 2018 08:16

brianteeman mentioned this pull request May 29, 2018

Adding notes to articles #20603

Closed

brianteeman restored the article-notes branch May 29, 2018 09:23

brianteeman reopened this May 29, 2018

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 29, 2018

mbabker added this to the Joomla 3.9.0 milestone Jun 2, 2018

mbabker changed the base branch from staging to 3.9-dev June 2, 2018 15:28

Merge branch '3.9-dev' into article-notes

3366d9f

joomla-cms-bot added the PR-3.9-dev label Jun 2, 2018

mbabker merged commit 46c840e into joomla:3.9-dev Jun 2, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 2, 2018

brianteeman deleted the article-notes branch June 2, 2018 17:46

zero-24 mentioned this pull request Jun 3, 2018

[3.9] [new feature] Article notes field joomlagerman/joomla#428

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[new feature] Article notes field #19134

[new feature] Article notes field #19134

brianteeman commented Dec 22, 2017 •

edited by joomla-cms-bot

csthomas Dec 22, 2017

brianteeman Dec 22, 2017

Quy Dec 22, 2017

Quy Dec 22, 2017

Quy Dec 22, 2017

brianteeman Dec 22, 2017

Quy Dec 22, 2017

Quy commented Dec 22, 2017

Quy Dec 22, 2017

brianteeman Dec 22, 2017

Quy commented Dec 23, 2017

alikon left a comment •

edited

brianteeman commented Dec 23, 2017

alikon commented Dec 24, 2017

ghost commented Dec 24, 2017

Quy commented Dec 24, 2017

Quy commented Dec 24, 2017

Quy commented May 29, 2018

brianteeman commented Jun 2, 2018

		@@ -0,0 +1,4 @@
		ALTER TABLE `#__content` ADD COLUMN `note` VARCHAR(255) NOT NULL DEFAULT '';

[new feature] Article notes field #19134

[new feature] Article notes field #19134

Conversation

brianteeman commented Dec 22, 2017 • edited by joomla-cms-bot

To test

Bonus

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Dec 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Dec 23, 2017

alikon left a comment • edited

Choose a reason for hiding this comment

brianteeman commented Dec 23, 2017

alikon commented Dec 24, 2017

ghost commented Dec 24, 2017

Quy commented Dec 24, 2017

Quy commented Dec 24, 2017

Quy commented May 29, 2018

brianteeman commented Jun 2, 2018

brianteeman commented Dec 22, 2017 •

edited by joomla-cms-bot

alikon left a comment •

edited