Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Page got trapped in modal-backdrop. #19408

Closed
anuragteapot opened this issue Jan 19, 2018 · 17 comments
Closed

[4.0] Page got trapped in modal-backdrop. #19408

anuragteapot opened this issue Jan 19, 2018 · 17 comments
Labels
No Code Attached Yet

Comments

@anuragteapot
Copy link
Contributor

anuragteapot commented Jan 19, 2018 •
edited by joomla-cms-bot
Loading

Steps to reproduce the issue

1.Try to edit an article (Open article editor page).
2.Then scroll the page down.
3.Click on the version or preview.

Expected result

screen shot 2018-01-19 at 14 51 18

Actual result

screen shot 2018-01-19 at 14 51 30

System information (as much as possible)

Joomla-Version:4.0.0-dev
OS:Linux

Additional comments
@anuragteapot
Copy link
Contributor Author

@franz-wohlkoenig can you test this issue.

@ghost
Copy link

ghost commented Jan 20, 2018

I'm not on Linux.

@anuragteapot
Copy link
Contributor Author

I am not sure, is this issue present on mac or not?

@ghost
Copy link

ghost commented Jan 20, 2018

OS:Linux

Means to me this happens only on Linux, so i didn't test.

Test now without Issue:

bildschirmfoto 2018-01-20 um 12 17 53

System information

4.0-dev
Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • Apache-Server
  • PHP 7.0.22
  • MySQLi 5.6.35

@anuragteapot
Copy link
Contributor Author

Did you scroll down like this? Then check

screenshot from 2018-01-20 16-52-36

It normally working if you don't scroll

@ghost
Copy link

ghost commented Jan 20, 2018

Works also if reduce Size of Browserwindow so i have to scroll down.

@anuragteapot
Copy link
Contributor Author

anuragteapot commented Jan 20, 2018 •
edited
Loading

Ok thanks,
Live demo of this issue https://www.youtube.com/watch?v=4Rj6VzlhLuU
Both in windows and Linux

@ciar4n
Copy link
Contributor

ciar4n commented Jan 20, 2018

Issue confirmed

Modal markup is inside the toolbar resulting in them sharing z-index when fixed. I suspect to amend this the modal markup needs outside of the toolbar.

@dgt41

@ghost ghost mentioned this issue Jan 26, 2018
Closed
@brianteeman brianteeman mentioned this issue Jan 31, 2018
Closed
@anuragteapot
Copy link
Contributor Author

@dgrammatiko can you please take a look here ?

@dgrammatiko
Copy link
Contributor

There are 3 moving parts here:

  • @ciar4n already has a PR for the sticking toolbar using only css
  • @Fedik has a PR for the new toolbar
  • we are working on a new accessible jquery free modal replacement

So although this is a real issue at the moment it should be fixed with either of the above mentioned PRs or the new modal

@ciar4n ciar4n mentioned this issue Apr 18, 2018
Merged
@brianteeman
Copy link
Contributor

Any update on the new modal its been 3 months

@brianteeman brianteeman mentioned this issue Jul 18, 2018
Closed
@bembelimen
Copy link
Contributor

If we get this issue fixed, then we can use the Patchtester in J!4, which would be a great help: joomla-extensions/patchtester#208

@brianteeman
Copy link
Contributor

@bembelimen you can still use it

@bembelimen
Copy link
Contributor

True, I can, but "normal" people get irritated. Just would be nice to have it done.

@brianteeman
Copy link
Contributor

yes it is irritating but it is still usable

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Aug 1, 2018
@brianteeman
[4.0] Modal trapped
f66c516 
PR for joomla#19408

I know that the modal code is going to be replaced eventually but this "trap" is preventing people from working with patchtester easily and from testing other part of joomla 4

(I am only committing the scss as I assume we no longer commit the compiled assets)
@brianteeman brianteeman mentioned this issue Aug 1, 2018
Merged
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/19408

@ghost
Copy link

ghost commented Aug 1, 2018

closed as having Pull Request #21343

@ghost ghost mentioned this issue Aug 1, 2018
Closed
wilsonge pushed a commit that referenced this issue Aug 19, 2018
@brianteeman @wilsonge
[4.0] Modal trapped (#21343)
302f10b 
PR for #19408

I know that the modal code is going to be replaced eventually but this "trap" is preventing people from working with patchtester easily and from testing other part of joomla 4

(I am only committing the scss as I assume we no longer commit the compiled assets)
@bembelimen bembelimen mentioned this issue Aug 26, 2018
Merged
@dgrammatiko dgrammatiko mentioned this issue Aug 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bembelimen @brianteeman @ciar4n @dgrammatiko @joomla-cms-bot @anuragteapot