Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Button text double translation #30935

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

brianteeman
Copy link
Contributor

Enable language debug
Open an article
On the save button dropdown you will see ??**Save to Menu**??

Apply the PR
Now the button is correctly displayed as **Save to Menu**

image

Enable language debug
Open an article
On the save button dropdown you will see `??**Save to Menu**??`

Apply the PR
Now the button is correctly displayed as `**Save to Menu**`
@infograf768
Copy link
Member

This is one solution.
The other is to modify ToolbarHelper and add 'save2menu' => 'JTOOLBAR_SAVE_TO_MENU', in the saveGroup method.

What do you think?

@brianteeman
Copy link
Contributor Author

I didnt see that - that would be much better. Closing this one here - can you make the PR?

@brianteeman brianteeman closed this Oct 6, 2020
@brianteeman brianteeman deleted the sk3 branch October 6, 2020 08:40
@infograf768
Copy link
Member

k

@infograf768
Copy link
Member

Please reopen. My solution does not work.

@brianteeman brianteeman restored the sk3 branch October 6, 2020 09:37
@brianteeman brianteeman reopened this Oct 6, 2020
@infograf768
Copy link
Member

I have tested this item ✅ successfully on c189bae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

1 similar comment
@ghost
Copy link

ghost commented Oct 6, 2020

I have tested this item ✅ successfully on c189bae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30935.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2020
@ghost
Copy link

ghost commented Oct 6, 2020

are ´??´always be reported? Like:

image

@brianteeman
Copy link
Contributor Author

We already have an issue open for that one #24168

@infograf768 infograf768 merged commit 2bdaf45 into joomla:4.0-dev Oct 6, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 6, 2020
@infograf768
Copy link
Member

Tks.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Oct 6, 2020
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the sk3 branch October 6, 2020 10:10
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Enable language debug
Open an article
On the save button dropdown you will see `??**Save to Menu**??`

Apply the PR
Now the button is correctly displayed as `**Save to Menu**`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants