Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] Correcting User Actions Log Manager when debug language is enabled #24178

Merged
merged 3 commits into from Mar 22, 2019

Conversation

Projects
None yet
5 participants
@infograf768
Copy link
Member

commented Mar 13, 2019

Pull Request for Issue #24164

Summary of Changes

Preventing translating urls

Testing Instructions

Enable Debug language in Global Configuration
Enable the Action Log - Joomla plugin
Go to Global Configuration
Click Save & close
Go to User -> User Action Log

Before patch

As urls pass through Text::_, they include ?? and links are broken.

After patch

All is fine.
Screen Shot 2019-03-13 at 07 18 14

@roland-d @alikon @HLeithner

@roland-d

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

I have tested this item successfully on 14e9079

After applying the patch, the username links work as expected by opening the user edit page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24178.

@alikon

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

I have tested this item successfully on 14e9079


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24178.

@infograf768 infograf768 removed the PR-staging label Mar 13, 2019

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.9.5 milestone Mar 13, 2019

@infograf768

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

RTC. Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24178.

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

rebooted drone on this one.

@zero-24 zero-24 merged commit 9d6238f into joomla:staging Mar 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 22, 2019

@zero-24

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

Merging thanks @infograf768

@infograf768 infograf768 deleted the infograf768:actionlogs_debuglang branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.