Correct implode() argument order for PHP 7.4 #25784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Aug 5, 2019
|
I have tested this item ✅ successfully on a1b3d38 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784. |
1 similar comment
|
I have tested this item ✅ successfully on a1b3d38 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25784. |
ghost
removed
the
|
Status "Ready To Commit". |
|
Thank you for the time you invest to make J3 PHP 7.4 compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changes
implode()argument order to solve deprecation messages in PHP 7.4:Testing Instructions
Code review.
Documentation Changes Required
No.