-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove Fade effect #27857
[4.0] Remove Fade effect #27857
Conversation
Faster login Solves stutter bug joomla#25904 Solves internet explorer bug joomla#26005
I have tested this item ✅ successfully on 2e3b4ee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857. |
Please don't delete |
But it's not being used after this pr |
Yes, but I want to add the LTR/RTL mixin from #27861 to |
Ok. Will do in the morning |
@Quy done as requested |
I have tested this item ✅ successfully on b932cb1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857. |
Tested with success, too. Will merge. |
Thanks. Btw. my nick name for my German friends is "Fade", so I first was confusde about the title ;-) |
@brianteeman Close #25904? |
@Quy you requested that this empty mixin file was not removed as you had a PR that would be using it In other words we should remove this empty file and references to it |
Thanks for the reminder. Removed in PR #31210. |
Summary of Changes
Faster login
Removes the delay which is counter-logic
Solves stutter bug #25904
#25904 (comment)
Solves internet explorer bug #26005
(of course it wont work nicely with IE but at least someone could now log in if they have an emergency AND it opens the possibility to add a "does not work with IE" message" which you can't before this PR
Testing Instructions
Apply PR and then run npm i
Check that login works
It should now be faster and smoother
Bonus try and open the admin with ie11
(First of several PR on atum)