Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove Fade effect #27857

Merged
merged 2 commits into from
Feb 9, 2020
Merged

[4.0] Remove Fade effect #27857

merged 2 commits into from
Feb 9, 2020

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

Faster login

Removes the delay which is counter-logic

Solves stutter bug #25904

#25904 (comment)

Solves internet explorer bug #26005

(of course it wont work nicely with IE but at least someone could now log in if they have an emergency AND it opens the possibility to add a "does not work with IE" message" which you can't before this PR

Testing Instructions

Apply PR and then run npm i

Check that login works
It should now be faster and smoother

Bonus try and open the admin with ie11

(First of several PR on atum)

Faster login
Solves stutter bug joomla#25904
Solves internet explorer bug joomla#26005
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Feb 8, 2020
@jwaisner
Copy link
Member

jwaisner commented Feb 8, 2020

I have tested this item ✅ successfully on 2e3b4ee

Login page no longer fades on login. Confirmed clean install is successful. Login is faster.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.

@Quy
Copy link
Contributor

Quy commented Feb 9, 2020

Please don't delete _mixin.scss and @import so the same mixin code for LTR/RTL can be implemented for the backend. Thanks.

@brianteeman
Copy link
Contributor Author

But it's not being used after this pr

@Quy
Copy link
Contributor

Quy commented Feb 9, 2020

Yes, but I want to add the LTR/RTL mixin from #27861 to _mixin.scss in Atum. Leave the file blank instead of deleting it please so I don't need to recreate it in my PR to come later.

@brianteeman
Copy link
Contributor Author

Ok. Will do in the morning

@brianteeman
Copy link
Contributor Author

@Quy done as requested

@Quy
Copy link
Contributor

Quy commented Feb 9, 2020

I have tested this item ✅ successfully on b932cb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.

@Quy
Copy link
Contributor

Quy commented Feb 9, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 9, 2020
@richard67
Copy link
Member

Tested with success, too. Will merge.

@richard67 richard67 merged commit 4739f91 into joomla:4.0-dev Feb 9, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 9, 2020
@richard67
Copy link
Member

Thanks. Btw. my nick name for my German friends is "Fade", so I first was confusde about the title ;-)

@richard67 richard67 added this to the Joomla 4.0 milestone Feb 9, 2020
@brianteeman brianteeman deleted the fade branch February 9, 2020 19:04
@Quy
Copy link
Contributor

Quy commented Feb 11, 2020

@brianteeman Close #25904?

@brianteeman
Copy link
Contributor Author

@Quy you requested that this empty mixin file was not removed as you had a PR that would be using it
its nine months later and the empty file is still there. did you forget your pr or was it done a different way.

In other words we should remove this empty file and references to it

@Quy
Copy link
Contributor

Quy commented Oct 22, 2020

Thanks for the reminder. Removed in PR #31210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants