[4.0] Add margin to back-top #27861
Merged
[4.0] Add margin to back-top #27861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on af7038d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27861. |
|
Thanks! |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 21, 2021
This mixin was aadded joomla#27861 But then the only place it was used was removed during joomla#31520 To test make a copy of templates\cassiopeia\css\template.css apply pr regenerate the css (node build/build.js --compile-css) compare the copy and the new template.css The only difference should be for .container-header .mod-finder > label which is not using the correct code. There should be no other differences. (I really dont understand why we have so many bootstrap overrides that dont do anything)
drmenzelit
pushed a commit
that referenced
this pull request
Feb 22, 2021
This mixin was aadded #27861 But then the only place it was used was removed during #31520 To test make a copy of templates\cassiopeia\css\template.css apply pr regenerate the css (node build/build.js --compile-css) compare the copy and the new template.css The only difference should be for .container-header .mod-finder > label which is not using the correct code. There should be no other differences. (I really dont understand why we have so many bootstrap overrides that dont do anything)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo #27315 using mixin.
Thanks @C-Lodder for the tip/code
Summary of Changes
Add margin to the back top icon.
Using mixin, it will generate LTR/RTL margin code.
Testing Instructions
Install Blog Sample Data
Apply PR
Run npm i
Go to front end and scroll to the bottom