Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Deleting Usergroups destroys view #28522

Closed
chmst opened this issue Mar 31, 2020 · 19 comments
Closed

[4.0] Deleting Usergroups destroys view #28522

chmst opened this issue Mar 31, 2020 · 19 comments

Comments

@chmst
Copy link
Contributor

chmst commented Mar 31, 2020

Steps to reproduce the issue

Go to usergroups.
Mark a group which has at least one subgroup, for example editor.
Delete it.

Expected result

The group is deleted,
The screen is reloaded and is complete, as usual.

Actual result

The group is deleted, but toolbar, modules on top and navigation are empty. It seems that there no modules are rendered.

screen shot 2020-03-31 at 08 49 09

System information (as much as possible)

Additional comments

@brianteeman
Copy link
Contributor

I can not replicate this

@ReLater
Copy link
Contributor

ReLater commented Mar 31, 2020

Neither do I. J4 nightly.

@astridx
Copy link
Contributor

astridx commented Mar 31, 2020

I can't replicate that either. I have created a group with two subgroups. I was able to delete them. Then I deleted the group editor because you gave this as an example. That was OK too.
Maybe you can narrow the error down?

Users  Groups   test   Administration
Users  Groups   test   Administration(1)

@chmst
Copy link
Contributor Author

chmst commented Mar 31, 2020

Strange, I had it permanently with several fresh installations. Can you re-try deleting several groups (with child groups) at the same time? I just deletd one group and it was comme il faut. Then I deleted two groups at the same time and the issue was as described.

@astridx
Copy link
Contributor

astridx commented Mar 31, 2020

I tested this and everything, including the toolbar and the sidebar, was OK.

You're still experiencing the problem. What group names do you use? Maybe there is something irrelevant.

Users  Groups   test   Administration(2)

@ReLater
Copy link
Contributor

ReLater commented Mar 31, 2020

Can't reproduce but I didn't use a fresh installation.

but I think I found another issue????

  1. Deleted 1 group "Publisher". OK. Message OK.

31-03-_2020_23-58-38

  1. Then I tried to delete several groups in one go and checked them all. See image:

31-03-_2020_23-56-25

No message(!) and several groups left:

01-04-_2020_00-06-59

@chmst
Copy link
Contributor Author

chmst commented Apr 5, 2020

After several new installations, I cannot reproduce the issue. Also deleting several groups works fine now.
@ReLater I could not reproduce your issue. PCould you open a new issue for that?
Then I colud close this one.

@ReLater
Copy link
Contributor

ReLater commented Apr 5, 2020

Ah, close please. Not that important for me.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @jwaisner by The JTracker Application at issues.joomla.org/joomla-cms/28522

@jwaisner
Copy link
Member

jwaisner commented Apr 7, 2020

Closing as this is not reproducible.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28522.

@joomla-cms-bot
Copy link

Set to "open" on behalf of @jwaisner by The JTracker Application at issues.joomla.org/joomla-cms/28522

@jwaisner
Copy link
Member

Confirmed on latest build. System info below:

PHP - 7.4.4
Database - MSQL 5.7.26
OS - Windows 10
Error Reporting - Maximum (no errors shown)

This was done with a complete wipe of all local data and SQL database.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28522.

@astridx
Copy link
Contributor

astridx commented Apr 13, 2020

My System Information for the tests last week

php: Linux astrid-TravelMate-5760G 4.15.0-96-generic #97-Ubuntu SMP Wed Apr 1 03:25:46 UTC 2020 x86_64
dbserver: mysql
dbversion: 5.7.29-0ubuntu0.18.04.1
dbcollation: utf8mb4_unicode_ci
dbconnectioncollation: utf8mb4_general_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.2.29-1+ubuntu18.04.1+deb.sury.org+1
server: Apache/2.4.29 (Ubuntu)

@richard67
Copy link
Member

richard67 commented Apr 13, 2020

I just could reproduce the issue by deleting the "Manager" user group (which deleted the administrator group too, because it's a child) on a fresh installed 4.0-dev without any sample data.

I don't know if it is related, but I noticed that the lftand rgtvalues in the user group table in database are not adjusted then the user group is deleted, see following 2 screenshots before and after.

Before:
j4_usergroup-delete-manager_table-before

After:
j4_usergroup-delete-manager_table-after

Patching the lftand rgtvalues in the database to the correct values doesn't help, the navigation menu, toolbar and so on is still disappeared.

Patched:
j4_usergroup-delete-manager_table-patched

j4_usergroup-delete-manager_view-after

@richard67
Copy link
Member

@ReLater Your finding above #28522 (comment) could be caused by what I found in my previous comment.

@richard67
Copy link
Member

Btw. I saw nothing in PHP error log or database server log.

@richard67
Copy link
Member

The issue I've found and mentioned in my comment above about lft and rgt values not being recalculated in the usergroups table is not related to this issue here and vice versa. My issue already exists in staging and 3.9.16. PR for my issue is #28684 .

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @SharkyKZ by The JTracker Application at issues.joomla.org/joomla-cms/28522

@SharkyKZ
Copy link
Contributor

Please test PR #28687.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants