Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Since today's merges toolbar button colors and other colors have gone #28906

Closed
richard67 opened this issue May 2, 2020 · 3 comments
Closed

Comments

@richard67
Copy link
Member

Steps to reproduce the issue

  1. Checkout currenmt 4.0-dev.

  2. Do composer install and npm ci.

  3. Make a new installation.

  4. Login to backend.

  5. Check colors of tool bar buttons in any tool bar.

Expected result

Some buttons have green and some red color depending on their purpose, at least that's what I remember how it looked yesterday. E.g. "Close" was red, "Save" was green and so on.

Actual result

All blue only.

j4-button-clolors-gone

System information (as much as possible)

4.0-dev of today, May 2, 15:00 UTC or later.

Additional comments

The toolbar buttons are only the most visible examples. To me it seems other colors have slightly changed, too.

@richard67 richard67 changed the title [4.0] Since today's merges button colors and other colors have gone [4.0] Since today's merges toolbar button colors and other colors have gone May 2, 2020
@richard67
Copy link
Member Author

@coolcat-creations Was that intended? It seems to come from #28788 .

@coolcat-creations
Copy link
Contributor

was not intended at all :-) Thank you for reporting, I will create a PR for this.

@brianteeman
Copy link
Contributor

Closed see #28907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants