Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Template Atum - Toolbar Button colors #28907

Merged
merged 1 commit into from
May 2, 2020
Merged

[4.0] Template Atum - Toolbar Button colors #28907

merged 1 commit into from
May 2, 2020

Conversation

coolcat-creations
Copy link
Contributor

Change Info buttons to use template variables

Pull Request for Issue #28906

Summary of Changes

  • Reverted changes from Fix Colorscheme #28788 and use special color for secodary and bg-atum-dark for the info buttons

Testing Instructions

  • apply patch
  • npm run build:css
  • check if save button icons and hover is green again, close red,... and so on
  • check with own colors in your custom template style, Info Buttons have now the dark color from the header, secondary buttons have now the link color.

Change Info buttons to use template variables
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2b896ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28907.

@richard67
Copy link
Member

@coolcat-creations Does that fix issue #28906 completely? If so, I will close the issue.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 2b896ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28907.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28907.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 2, 2020
@wilsonge wilsonge merged commit 7ffc0f8 into joomla:4.0-dev May 2, 2020
@wilsonge
Copy link
Contributor

wilsonge commented May 2, 2020

Thankyou!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 2, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone May 2, 2020
@richard67
Copy link
Member

Thanks god my beloved green and red colors are back 😄

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Change Info buttons to use template variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants