Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [com_workflow] Parameterized queries #29633

Merged
merged 4 commits into from
Jun 16, 2020
Merged

[4.0] [com_workflow] Parameterized queries #29633

merged 4 commits into from
Jun 16, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jun 16, 2020

Summary of Changes

Converts to parameterized queries.

Testing Instructions

Use com_workflow in every way possible.
Create/edit/delete workflows/stages/transitions.
Use filter and ordering options in list views.

Expected result

Works like before.

Documentation Changes Required

No.

@richard67
Copy link
Member

@SharkyKZ How is that related to the PR #29207 you've referenced in the description? Or is it maybe a typo?

@SharkyKZ
Copy link
Contributor Author

Some typo.

@Quy
Copy link
Contributor

Quy commented Jun 16, 2020

Searching in Transitions returns no results. This is the same without this PR.

@SharkyKZ
Copy link
Contributor Author

@Quy please test PR #29643.

@Quy
Copy link
Contributor

Quy commented Jun 16, 2020

I have tested this item ✅ successfully on 54466e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29633.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 121bb31


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29633.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29633.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2020
@richard67
Copy link
Member

Test result of Quy was still valid because merge after that was just update to base branch.

@wilsonge wilsonge merged commit b09f7f7 into joomla:4.0-dev Jun 16, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 16, 2020
@SharkyKZ SharkyKZ deleted the j4/prepared/com-workflow branch June 16, 2020 20:31
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants