-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Implementing display of password minimum requirements for frontend registration #30473
Conversation
Thanks @infograf768 |
I have tested this item ✅ successfully on e75237e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473. |
I have tested this item ✅ successfully on e75237e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473. |
Repeating my objection to the use of the word digits. It should be numbers as in this password is made up of numbers and letters |
As I said, if you do not like it, this term has to be modified all over the strings, including the existing error ones. |
yay for knowingly merging a string that is wrong so it can be changed later. whoopee for making more work because you are stubborn and insist that you know english better than anyone else |
I have checked this with my client Cambridge University Press and they have checked the usage within the Corpus. https://en.wikipedia.org/wiki/Cambridge_English_Corpus The corpus is a multi billion word database of the usage of the english language in the world. The corpus is about how language is used and not just about the dictionary meaning They wrote
|
I have contacted the great Mamamouchi ( https://wordhistories.net/2016/10/18/mamamouchi/ ) and informed him about this post. His reply was quite interesting.
I asked then the great Mamamouchi what was the GAFA's interest in this misuse of the language of Shakespeare. He replied:
"How is that?", I asked.
"Interesting!", I said. "Then what shall I reply to the person who posted his feeling on this matter?"
"Wow!" I said. "We would also have to change |
very funny but completely irrelevant. |
I agree with Brian with numbers vs digits (personally I don’t think I’ve ever used the word digit properly other than to describe my fingers and toes :p and that includes during my physics degree 🤪). |
@wilsonge so why did you merge it |
…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: (70 commits) [4.0] Child templates consistency (joomla#30387) [4.0] favicon changes to support child templates (joomla#30388) [4.0] Update Readme for Api tests (joomla#30539) [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537) [4.0] Display of horizontal mod_articles_news module (joomla#30527) [4.0] Useless installation lang strings (joomla#30568) [4.0] Numbers not digits (joomla#30559) [4.0] Accessibility plugin position (joomla#30552) [4.0] fix for inherit fields (joomla#30557) [4.0] Redundant words (joomla#30555) add missing legend to fieldset (joomla#30528) [4.0] [a11y] add statement on found results (joomla#30535) [4.0] com_finder ul instead of dl for easier styling (joomla#30534) [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516) [4.0] Increase API Test Coverage (joomla#26722) [4.0] Implementing display of password requirements for frontend (joomla#30473) [4.0] FieldsHelper: Choose a first available category correctly (joomla#30268) Sort options (joomla#30531) Clear checkboxes on back button (joomla#30498) Update _icomoon.scss (joomla#30436) ...
Replaces #30456
Summary of Changes
Instead of using a tooltip in #30456, this displays the requirements as a description on top of the field.
The new xml attribute is
rules="true"
. This lets developers chose to display or not these.The code does not change the J installation password string.
Testing Instructions
Define Password requirements in Users Options=>Tab Password Options
No need for npm. Does not change any CSS.
Actual result BEFORE applying this Pull Request
The password field does not indicate any requirements, forcing the new user to enter stuff and then modify depending on the Errors messages.
Expected result AFTER applying this Pull Request
When set to 0, the requirement is not displayed
Installation tip is not modified
Documentation Changes Required
Yes, including the meter which is new in 4.0
Note
If this is accepted, we can implement in other core places by just adding the description string and the new attribute.
@zero-24