Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Implementing display of password minimum requirements for frontend registration #30473

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

infograf768
Copy link
Member

Replaces #30456

Summary of Changes

Instead of using a tooltip in #30456, this displays the requirements as a description on top of the field.

The new xml attribute is rules="true". This lets developers chose to display or not these.
The code does not change the J installation password string.

Testing Instructions

Define Password requirements in Users Options=>Tab Password Options
No need for npm. Does not change any CSS.

Actual result BEFORE applying this Pull Request

The password field does not indicate any requirements, forcing the new user to enter stuff and then modify depending on the Errors messages.

Expected result AFTER applying this Pull Request

Screen Shot 2020-08-25 at 10 23 55

When set to 0, the requirement is not displayed

Screen Shot 2020-08-25 at 10 27 10

Installation tip is not modified

Screen Shot 2020-08-25 at 10 24 52

Documentation Changes Required

Yes, including the meter which is new in 4.0

Note

If this is accepted, we can implement in other core places by just adding the description string and the new attribute.

@zero-24

@zero-24
Copy link
Contributor

zero-24 commented Aug 25, 2020

Thanks @infograf768

@Magnytu2
Copy link

Test ok, the information is there.
Enregistrement

@Magnytu2
Copy link

I have tested this item ✅ successfully on e75237e

Test ok, the information is there.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473.

@ceford
Copy link
Contributor

ceford commented Aug 25, 2020

I have tested this item ✅ successfully on e75237e

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30473.

@richard67 richard67 removed Language Change This is for Translators PR-4.0-dev labels Aug 25, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 25, 2020
@richard67 richard67 added Language Change This is for Translators PR-4.0-dev labels Aug 25, 2020
@brianteeman
Copy link
Contributor

Repeating my objection to the use of the word digits. It should be numbers as in this password is made up of numbers and letters
This is the same usage as google, twitter and facebook.

@infograf768
Copy link
Member Author

As I said, if you do not like it, this term has to be modified all over the strings, including the existing error ones.
You are free, once this is merged, to propose a PR.

@brianteeman
Copy link
Contributor

yay for knowingly merging a string that is wrong so it can be changed later. whoopee for making more work because you are stubborn and insist that you know english better than anyone else

@brianteeman
Copy link
Contributor

I have checked this with my client Cambridge University Press and they have checked the usage within the Corpus. https://en.wikipedia.org/wiki/Cambridge_English_Corpus The corpus is a multi billion word database of the usage of the english language in the world. The corpus is about how language is used and not just about the dictionary meaning

They wrote

Interesting! I’ve had a look and it looks like ‘number’ is more common – there are only a small number of examples with ‘digit’.

It’s hard to know for sure, as there are only very few examples of the exact sentences you’ve given so I did a more general search and often ‘number’ is used in sentences like ‘they could steal your credit card number and password’. But, I had a scan through and there are definitely lots of examples of e.g. ‘use a password that contains letters, numbers and special characters’, so I think you’re right to go with your feeling on this.

@infograf768
Copy link
Member Author

I have contacted the great Mamamouchi ( https://wordhistories.net/2016/10/18/mamamouchi/ ) and informed him about this post.

His reply was quite interesting.

English is quite a simplistic language. Example: it does not differentiate a street number from a mathematical number, both being composed with digits.
But it looks like the important use of number instead of the correct English digit in the case at stake is simply due to what many call "American cultural imperialism" imposed by the GAFA (Google, Amazon, Facebook, Apple).

I asked then the great Mamamouchi what was the GAFA's interest in this misuse of the language of Shakespeare. He replied:

Interesting! I have been wondering too about that. I came to the conclusion that it has to do with their conception of taxes.

"How is that?", I asked.

Well, as everybody knows, the GAFA try by all means to pay the less taxes possible all over the world. Their "deep state" aim is to pay only one digit of the kind of currency used in each country. Therefore only digits from 0 to 9. Example: 1 Euro per year in the European Union, 2 Dollars in the USA, etc.

Using the term number instead of digit is an attempt at making people believe that the GAFA do pay a normal amount of taxes.

"Interesting!", I said. "Then what shall I reply to the person who posted his feeling on this matter?"

Simple. Let him create a specific proposal to change all instances of "American cultural imperialism" in your software.

"Wow!" I said. "We would also have to change In the trash to In the dustbin"

@brianteeman
Copy link
Contributor

very funny but completely irrelevant.

@wilsonge wilsonge merged commit 27dda3e into joomla:4.0-dev Sep 1, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 1, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Sep 1, 2020

I agree with Brian with numbers vs digits (personally I don’t think I’ve ever used the word digit properly other than to describe my fingers and toes :p and that includes during my physics degree 🤪).

@brianteeman
Copy link
Contributor

@wilsonge so why did you merge it

dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms: (70 commits)
  [4.0] Child templates consistency (joomla#30387)
  [4.0] favicon changes to support child templates (joomla#30388)
  [4.0] Update Readme for Api tests (joomla#30539)
  [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537)
  [4.0] Display of horizontal mod_articles_news module (joomla#30527)
  [4.0] Useless installation lang strings (joomla#30568)
  [4.0] Numbers not digits (joomla#30559)
  [4.0] Accessibility plugin position (joomla#30552)
  [4.0] fix for inherit fields (joomla#30557)
  [4.0] Redundant words (joomla#30555)
  add missing legend to fieldset (joomla#30528)
  [4.0] [a11y] add statement on found results (joomla#30535)
  [4.0] com_finder ul instead of dl for easier styling (joomla#30534)
  [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516)
  [4.0] Increase API Test Coverage (joomla#26722)
  [4.0] Implementing display of password requirements for frontend (joomla#30473)
  [4.0] FieldsHelper: Choose a first available category  correctly (joomla#30268)
  Sort options (joomla#30531)
  Clear checkboxes on back button (joomla#30498)
  Update _icomoon.scss (joomla#30436)
  ...
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants