Add Button margins when update

[mariantanase]

Steps to reproduce the issue

When upgrading from Joomla 4 Beta 7 to the current nightly build, you are prompted to enter credentials before continuing.
The two buttons (Cancel and Install) are attached. No margin or padding between them.

Expected result

Actual result

System information (as much as possible)

Joomla_4.0.0-beta8-dev
PHP 7.4.13

Additional comments

[akashniyal]

Sir, let me get a chance to fix this issue.

[alikon]

maybe reading this one #32697 may help

[richard67]

Whoever wants to fix this issue mind the round corners of the button: When having space between the buttons, it will need all 4 corners of each button to be round.

[JajateeNandineeSahoo]

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

[shitesh2607]

I am working on this issue.

[infograf768]

Suggestion:

diff --git a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
index bc7b120..78bc0f9 100644
--- a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
+++ b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php
@@ -85,12 +85,12 @@
 		<div class="control-group">
 			<div class="controls">
-				<div class="btn-group">
+				<button type="button" class="btn">
 					<a class="btn btn-danger" href="index.php?option=com_joomlaupdate">
 						<span class="icon-times icon-white" aria-hidden="true"></span> <?php echo Text::_('JCANCEL'); ?>
 					</a>
-					<button type="submit" class="btn btn-primary">
-						<span class="icon-play icon-white" aria-hidden="true"></span> <?php echo Text::_('COM_INSTALLER_INSTALL_BUTTON'); ?>
-					</button>
-				</div>
+				</button>
+				<button type="submit" class="btn btn-primary">
+					<span class="icon-play icon-white" aria-hidden="true"></span> <?php echo Text::_('COM_INSTALLER_INSTALL_BUTTON'); ?>
+				</button>
 			</div>
 		</div>

[JajateeNandineeSahoo]

I am working on this issue.

Okay, no problem but I just want to know that can't I work on this issue? Is it that only a single person can work on a single issue?

[mariantanase]

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

I'm sorry to tell you this, but how can you fix this issue when you don't know where to find the code to fix ?

[chmst]

@JajateeNandineeSahoo you can work on this issue - everyone can work on every issue. As soon as you make a pullrequest which solves the problem, the issue will be closed and we test your PR.

[JajateeNandineeSahoo]

I want to fix the issue but don't know where is the code this issue. Could anyone help me and tell what is the path to get the code?

I'm sorry to tell you this, but how can you fix this issue when you don't know where to find the code to fix ?

Actually I'm new to open source and I don't know much about it. I'm just started learning it and I thought that may be someone would have written the path to find the code.

[infograf768]

the path is easy. look above : #32700 (comment)

[drmenzelit]

Closing as we have a PR #32716

[infograf768]

My proposal above #32700 (comment) is wrong.

[infograf768]

Maybe this will be OK

#32716 (comment)

Reopening

[drmenzelit]

I'm closing the issue since it is the expected behaviour of a btn-group to have the buttons together without space between them: https://getbootstrap.com/docs/5.0/components/button-group/

Feel free to re-open if you think the btn-group is wrong here.