[3.10] Disable the critical plugins check for non-major updates.

[zero-24]

Summary of Changes

Disable the critical plugins check for non-major updates for example when updating between 3.10 -> 3.10

Testing Instructions

Install 3.10-rc2
Install https://regularlabs.com/whatnothing
Use the nighly update server: https://update.joomla.org/core/nightlies/next_minor_list.xml

Set the update server to 4: https://update.joomla.org/core/nightlies/next_major_list.xml
than you get the warning again

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

None

cc @joomla/cms-release-team @HLeithner @bembelimen

[alikon]

I have tested this item ✅ successfully on ad540f7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35105.}

[zero-24]

Thanks 👍

[regularlabs]

Will the same be applied to the check in Joomla 4?

[zero-24]

On a quick look i would say no cause a plugin that is installed into 4.0 should have declared himself to be compatible with 4.0 right? Or do I miss something?

[regularlabs]

Not all extensions have (or can have) update sites attached to them. So the pre-update check is unable to check if it is compatible or not.
So that means you get warnings for every minor Joomla update.

Also: the same situation will present itself when there will be a Joomla 5...

[zero-24]

Ok fine for me than to adjust the check in 4.0 to do the check only for joomla 5 cc @wilsonge when you merge this one up.