[3.10] Add a check whether we are running the core backend template and issue an info when that is not the case

[zero-24]

Summary of Changes

Add a check whether we are running the core tempaltes where the backend it required and the frontend is recommended

Testing Instructions

• Install 3.10.0
• install a non-core backend template (https://www.joomlatema.net/joomla-templates/free-joomla-templates/adminim-free-joomla-administrator-template.html)
• set the template as default for the backend
• apply this patch
• point the update server to joomla 4 via the Joomla Next update server
• notice the new message

Actual result BEFORE applying this Pull Request

No checks for the default templates

Expected result AFTER applying this Pull Request

Documentation Changes Required

https://docs.joomla.org/Pre-Update_Check - Has to be updated

TTs have to be informed about the language stirngs

cc @joomla/cms-release-team @HLeithner @bembelimen

[brianteeman]

These are NOT php or database settings

Core backend template is NOT a requirement

[brianteeman]

I have tested this item 🔴 unsuccessfully on 33a0aed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35107.}

[zero-24]

Core backend template is NOT a requirement

Will move it to the optional thing than fine for me.

These are NOT php or database settings

Agree its on my list to be updated too.

[zero-24]

The requested changes have been pushed. They are now both under "the seccond box" and the title has been updated too.

[brianteeman]

why check for isis? there is more than 1 admin template

[brianteeman]

Neither of these checks are anything to do with compatibility. They are only really needed to perhaps make the update easier. This is just creating FUD

[richard67]

Here in the 4.0 update SQL we check for hathor and isis and update to atum if one of these is used: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-03-05.sql#L23

And one row below we check for protostar and beez 3 for the frontend.

So why do the language strings added by this PR here not mention hathor or beez3? It should work same well as with the other core templates.

We should not provide false information in language strings which are made to guide people.

[brianteeman]

This and the other PR should be closed and re-evaluated. There is ZERO reason for either PR.

Not withstanding the code issues the concept of both PR is wrong!! They only succeed in spreading fear, uncertainty and doubt about the upgrade process.

I can't believe you are even remotely thinking about such a change after the final release candidate.

[brianteeman]

I have tested this item 🔴 unsuccessfully on 164496e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35107.}

[zero-24]

So why do the language strings added by this PR here not mention hathor or beez3? It should work same well as with the other core templates.

Isnt hathor gone already? I can add them for sure.

I can't believe you are even remotely thinking about such a change after the final release candidate.

It has been raised by the @joomla/cms-release-team that there should be messages like that. I see where an "pre upgrade checker" could warn about such issues that affect the site performance after the upgrade or the upgrade process.

For example an non-core backed templates or non-core frotend template could break the site once upgraded so the recommendation would be for the time of the upgrade to switch to the core where we know that the upgrade works and they are beeing replaced by 4.x compatible code than you can go and enable the other stuff step by step too.

The router stuff is something different happening under the hood so the idea was to tell the people that there could be changes in the URLs joomla generates after the upgrade.

[brianteeman]

Isnt hathor gone already?

No - just not supported. You obviously didnt even check. https://github.com/joomla/joomla-cms/tree/3.10-dev/administrator/templates

It has been raised by the @joomla/cms-release-team that there should be messages like that.

Excuse my language but "a bit bloody late"

For example an non-core backed templates or non-core frotend template could break the site once upgraded so the recommendation would be for the time of the upgrade to switch to the core where we know that the upgrade works and they are beeing replaced by 4.x compatible code than you can go and enable the other stuff step by step too.

But that is not what you are doing or saying with these pr

The router stuff is something different happening under the hood so the idea was to tell the people that there could be changes in the URLs joomla generates after the upgrade.

Again that is not what is being done or said with these PR.

[zero-24]

No - just not supported. You obviously didnt even check. https://github.com/joomla/joomla-cms/tree/3.10-dev/administrator/templates

Hmm I'm sure we did a postinstall for hathor users but yes seems its still shipped.

But that is not what you are doing or saying with these pr

Than its great that you raised this questions so that this can be clarified. What can be done to do what I'm trying to do?

[zero-24]

Will leave it for today, but want to go back later to Isis and J 3.10.1 again :-)

The message seems to be correct to me, so this would be a successfull test. :)

[ChristineWk]

I have tested this item ✅ successfully on ad7b419

But it's not in blue :-)
Would also prefer to switch to Isis before updating. Similar to the frontend template on Protostar (if you were on a copy)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35107.}

[zero-24]

But it's not in blue :-)

I have just double checked that, it seems the template does not show "info" as blue. But isis does so it seems the template decided to show information messages in yellow which is a chooise of the template.

[zero-24]

Sorry but the warning message position is completely the wrong place for it in my opinion.

I'm sorry @HLeithner seems I have missed this comment. Do you have another proposal where that message should be shown while it should only be shown too a small number of sites anyway right?

[HLeithner]

like all other warnings, maybe in a new section.

[zero-24]

like all other warnings, maybe in a new section.

What kind of new section do you have in mind?

[zero-24]

@HLeithner can we get a response here so the PR can be adjusted or closed based on the feedback?

[HLeithner]

I thought about something like "Required PHP & Database Settings".

[zero-24]

Is it required or an php or database setting? This is exactly the place where all of this started but it was moved outside of this checks for that reason and moved into a standalone blue message.

[HLeithner]

not in this box, a new box like this box

[zero-24]

And how would you call it, what would we show when you are running isis? Just as a reminder its only showed when you have a non-isis backend template?

[zero-24]

Will take this now in as it is for now. When we find better ways to display it I'm open to change it.