Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] TinyMCE option to initially paste text without formatting #36328

Merged
merged 10 commits into from
Jan 10, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 16, 2021

Pull Request for forum post https://forum.joomla.org/viewtopic.php?t=971958.

Summary of Changes

Adds an option that text pasted into an editor field of TinyMCE will be without formatting. This can be controlled on a set level.

Basically it controls this TinyMCE option https://www.tiny.cloud/docs/plugins/opensource/paste/#paste_as_text

Testing Instructions

  • Set the "Paste As Text" option to "On" in TinyMCE plugin in all sets.
  • Open the article form
  • Copy text from this pr description with links into the description field

Actual result BEFORE applying this Pull Request

Formatting with links is inserted.

Expected result AFTER applying this Pull Request

Only raw text is inserted with new lines.

@brianteeman
Copy link
Contributor

do we really need another option when you can paste as text already

image

@laoneo
Copy link
Member Author

laoneo commented Dec 16, 2021

Sure, because this is not a view where you can do an override. So the only way is to add new options.

Pasting text is especially helpful when you have a forum or ticket tool, where users paste blindly any kind HTML into the form.

@bembelimen
Copy link
Contributor

bembelimen commented Dec 17, 2021

I think this option is very useful, but I guess 4.1 as it's a feature?

@laoneo
Copy link
Member Author

laoneo commented Dec 17, 2021

I would more say it is an enhancement

@laoneo laoneo changed the base branch from 4.0-dev to 4.1-dev January 3, 2022 12:58
@laoneo laoneo changed the title [4.0] TinyMCE option to initially paste text without formatting [4.1] TinyMCE option to initially paste text without formatting Jan 3, 2022
@laoneo
Copy link
Member Author

laoneo commented Jan 3, 2022

Ok, changed to 4.1.

@laoneo laoneo removed the PR-4.0-dev label Jan 3, 2022
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 2c00ed6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36328.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on db16d2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36328.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jan 8, 2022

I have tested this item ✅ successfully on db16d2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36328.

@alikon
Copy link
Contributor

alikon commented Jan 8, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36328.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 8, 2022
@laoneo
Copy link
Member Author

laoneo commented Jan 9, 2022

@bembelimen the System tests errors are not related to this pr

@bembelimen bembelimen merged commit 500318f into joomla:4.1-dev Jan 10, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Jan 10, 2022
@laoneo laoneo deleted the j4/mce/paste branch January 10, 2022 05:36
heelc29 added a commit to heelc29/joomla that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants