-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1]Add form layout option to custom fields #36551
Conversation
Otherwise everything looks great to me |
No, this looks like an init issue on the JS part which I didn't touch. But could also not reproduce the issue on my end. |
ok |
I have tested this item ✅ successfully on 5da3d2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36551. |
1 similar comment
I have tested this item ✅ successfully on 5da3d2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36551. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36551. |
I have tested this item ✅ successfully on 5da3d2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36551. |
I reproduced part of Brian's issue. It's because the layout expects the values to be in the order of No - Yes; if they are flipped, it doesn't respect that. I'm wondering if there is any way to detect the values of 0/1 or true/false or yes/no and make it a bit 'smarter'? I'm not sure this is something that would prevent merging the PR, but wanted to clarify the bug. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36551. |
Thanks for clarification. When the order mathers, then we need to mention this in the docs. If this should be handled on the code side, then I would do it in another pr. |
Thx |
Can you guys also test #36553 which does the same for the color field. |
joomla/joomla-cms#30522 + joomla/joomla-cms#32223 + joomla/joomla-cms#31675 + joomla/joomla-cms#35378 + joomla/joomla-cms#35612 + joomla/joomla-cms#35715 + joomla/joomla-cms#35610 + joomla/joomla-cms#35607 + joomla/joomla-cms#35788 + joomla/joomla-cms#35647 + joomla/joomla-cms#35143 + joomla/joomla-cms#36135 + joomla/joomla-cms#35998 + joomla/joomla-cms#36173 + joomla/joomla-cms#36212 + joomla/joomla-cms#36208 + joomla/joomla-cms#36206 + joomla/joomla-cms#36205 + joomla/joomla-cms#36203 + joomla/joomla-cms#36192 + joomla/joomla-cms#36191 + joomla/joomla-cms#36228 + joomla/joomla-cms#36211 + joomla/joomla-cms#36271 + joomla/joomla-cms#36270 + joomla/joomla-cms#36245 + joomla/joomla-cms#36294 + joomla/joomla-cms#36244 + joomla/joomla-cms#36242 + joomla/joomla-cms#36296 + joomla/joomla-cms#36190 + joomla/joomla-cms#36474 + joomla/joomla-cms#36297 + joomla/joomla-cms#36480 + joomla/joomla-cms#36479 + joomla/joomla-cms#36551 + joomla/joomla-cms#36366 + joomla/joomla-cms#36589 + joomla/joomla-cms#36583 + joomla/joomla-cms#36328 + joomla/joomla-cms#36515 + joomla/joomla-cms#36555 + joomla/joomla-cms#36653 + joomla/joomla-cms#36660 + joomla/joomla-cms#36657 + joomla/joomla-cms#36637 + joomla/joomla-cms#35983 + joomla/joomla-cms#36704 + joomla/joomla-cms#36708 + joomla/joomla-cms#36700 +
@laoneo I just ran into this and I noticed this is the wrong placement for this setting. The "Options" tab is dedicated to global settings that are shared by all field types. It's not the place to add type-specific settings. Options tied to specific types of fields should be added in the first "General" tab. This is what has always been done for all field types and field settings. So this new "Form Layout" should be moved under the "General" tab for all the fields in which you added it. For example, under the "Multiple" setting: But: Do we even need this setting at all? I would argue: do we really need a setting? The other "raw" layout is ugly and unusable. I don't think anyone will ever want to use it. The new one it's just better, and it's similar to what he had in J3. I personally would just implement the "enhanced select" by default, and get rid of the other layout altogether. Like we had in J3. What do you think? |
Please open a new issue, so it can be discussed properly as this pr is closed. |
Pull Request for Issue #36548.
Summary of Changes
Makes the form layout for custom field configurable. Actually only for the following fields:
Any suggestions for language strings?
Testing Instructions
Actual result BEFORE applying this Pull Request
The list is rendered with the default select HTML Element.
Expected result AFTER applying this Pull Request
The list is rendered with the choices.js script.