[4.1] Template Override switches

[brianteeman]

For some reason the switches were not displayed in the same way as other similar switches. This leads to confusion (reported elsewhere) and the need for creating additional css.

This Pr resolves that. Made against 4.1 as there are language string removals and additions and I dont know what the policy is for that in j4.

Before

After

cc @Scrabble96

[Quy]

PHP Notice: Undefined property: Joomla\Component\Templates\Administrator\View\Template\HtmlView::$mediaFiles in \administrator\components\com_templates\tmpl\template\default.php on line 100

Warning: count(): Parameter must be an array or an object that implements Countable in \administrator\components\com_templates\tmpl\template\default.php on line 100

[brianteeman]

@Quy I cannot replicate your error report and there is nothing in this PR remotely related to the line mentioned

[Quy]

Sorry false alarm. Applied to v4.0. OK in v4.1.

[sandewt]

Why a boolean ? Is this an appointment within Joomla ?

See https://www.php.net/manual/en/language.types.boolean.php

[Quy]

I have tested this item ✅ successfully on b17288b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.}

[sandewt]

I want to test, but I can't find these switches. 😅
How to do?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.}

[brianteeman]

@sandewt They only display when you are working on a template override. So use the create override functionality and then select one of the newly created overrides and then you will see the switches in the top right

[sandewt]

With a little trick I can make the buttons visible and get the following. The text is not inline with the buttons. This depends on the screen size.

[Quy]

@sandewt Please run npm i to compile the CSS changes or download/install the prebuilt package.

[chmst]

I am not in favour of this kind of switches. Switches should be for yes/no only (I know that we have several on other places, and i think it is always wrong).

Why not use a label? like "Hide original file: yes/no?"

[brianteeman]

I know that we have several on other places, and i think it is always wrong).

so propose a change. this pr is consistent with current usage

[chmst]

What is current usage?

[brianteeman]

What is current usage?

Verbs shoud be avoided in labels

[chmst]

Probably there is a reason for this rule, and maybe I am wrong with my my personal opinion, that switches should be used only for yes/no and lists for text-alternatives.

If you were German I could help very easily, we can make a noun from every verb :) "Versteckthaltung der Originaldatei"

I will start a discussion for that, because I think it is important. But not directly related to this PR.

[chmst]

I have tested this item ✅ successfully on 9b37b14

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.}

[chmst]

This solution is better than before.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.}

[bembelimen]

Thx

[brianteeman]

thanks