Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] jooa11y plugin options #37196

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

In the initial pull request the removal of some options went too far and stopped the remaining options from working. This resolves that.

This pr also changes the description of the containers to include examples of using classes, divs and roles

Before this PR none of the options were used. Now they are.

In the initial pull request the removal of some options went too far and stopped the remaining options from working. This resolves that.

This pr also changes the description of the containers to include examples of using classes, divs and roles

Before this PR none of the options were used. Now they are.
@richard67
Copy link
Member

I have tested this item ✅ successfully on d151e21

Without the fix, parameters are not used. With the fix they are.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37196.

@khu5h1
Copy link
Contributor

khu5h1 commented Mar 3, 2022

I have tested this item ✅ successfully on a8836e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37196.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on a8836e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37196.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37196.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2022
@bembelimen bembelimen merged commit 2496df4 into joomla:4.1-dev Mar 7, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2022
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1.1 milestone Mar 7, 2022
@brianteeman
Copy link
Contributor Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants