Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Change tags plugin to service provider #37928

Merged
merged 5 commits into from
Jun 12, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 30, 2022

Summary of Changes

Change tags plugin to service provider. Did also some code style cleanup.

Testing Instructions

  • Open the article form
  • Define some tags
  • Save the article

Actual result BEFORE applying this Pull Request

Tags are stored and assigned to the new article.

Expected result AFTER applying this Pull Request

Tags are stored and assigned to the new article.

laoneo and others added 2 commits June 4, 2022 19:13
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 00fc446

Add, remove tags, batch assign tags, all still works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37928.

@alikon
Copy link
Contributor

alikon commented Jun 11, 2022

I have tested this item ✅ successfully on 00fc446


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37928.

@alikon
Copy link
Contributor

alikon commented Jun 11, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37928.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 11, 2022
@roland-d roland-d merged commit 855f050 into joomla:4.2-dev Jun 12, 2022
@roland-d roland-d deleted the j4/plugins/tags branch June 12, 2022 08:06
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
roland-d pushed a commit that referenced this pull request Jun 20, 2022
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants