Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Convert mod_articles_latest to new structure #37947

Merged
merged 4 commits into from Jun 12, 2022

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR converts mod_articles_latest to new structure

Testing Instructions

  1. Use Joomla 4.2
  2. Create an instance of Articles - Latest module. Note how it works.
  3. Apply patch
  4. Delete administrator/cache/autoload_psr4.php
  5. Refresh the page, make sure the module still displays the same as before.

@richard67
Copy link
Member

@joomdonation Could you fix the PHP CS issue reported by drone?

@toivo
Copy link
Contributor

toivo commented Jun 1, 2022

I have tested this item ✅ successfully on 5baff2a

Tested successfully in Joomla 4.2.0-beta1-dev of 1 June.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@pabloarias
Copy link

I have tested this item ✅ successfully on 5baff2a

Hello:

I used Joomla! version 4.2.0-beta1-dev and PHP 8.1.5.

Installed Blog Sample Data and created module Articles - Latest. It works fine.

If I delete the file before apply the path, it works fine.

After applying the path, it works too.

Thank you and best regards


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37947.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2022
@roland-d roland-d merged commit 42e25d6 into joomla:4.2-dev Jun 12, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
@joomdonation joomdonation deleted the covert_mode_articles_latest branch June 12, 2022 09:39
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
roland-d pushed a commit that referenced this pull request Jun 20, 2022
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants