Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Default" layout really as default #38729

Merged
merged 2 commits into from Oct 7, 2022

Conversation

n3t
Copy link
Contributor

@n3t n3t commented Sep 8, 2022

Use "Default" layout as default upon creating new menu module.

Summary of Changes

Added default value to mod_menu.xml

Testing Instructions

Go to module manager and create new module of type Menu.

Actual result BEFORE applying this Pull Request

Module is created and in Layout field (tab Advanced) is preselected "Collapsible Default menu".

Expected result AFTER applying this Pull Request

Module is created and in Layout field (tab Advanced) is preselected "Default".

Documentation Changes Required

No

Use "Default" layout as default upon creating new menu module.
@PhocaCz
Copy link
Contributor

PhocaCz commented Sep 28, 2022

I have tested this item ✅ successfully on 91da17a

Hi, tested successfully.

https://i.imgur.com/MMOPwsQ.png


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38729.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 91da17a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38729.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38729.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2022
@roland-d roland-d merged commit 54a82bc into joomla:4.2-dev Oct 7, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 7, 2022
@roland-d
Copy link
Contributor

roland-d commented Oct 7, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.4 milestone Oct 7, 2022
@n3t n3t deleted the n3t-patch-menu-module branch October 7, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants