Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Columns js #38723

Merged
merged 2 commits into from Sep 15, 2022
Merged

Table Columns js #38723

merged 2 commits into from Sep 15, 2022

Conversation

brianteeman
Copy link
Contributor

Although not used in core the issue raised #38729 makes sense and might be used by extensions

Testing either by code review or by adding the d-xs-, d-sm-, d-xxl- classes to an existing table

As it is a js change you will need to test with either a pre-built package from the links below or to apply the pr and run npm run build:js

Although not used in core the issue raised joomla#38729 makes sense and might be used by extensions

Testing either by code review or by adding the d-xs-, d-sm-, d-xxl- classes to an existing table

As it is a js change you will need to test with either a pre-built package from the links below or to apply the pr and run `npm run build:js`
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Sep 8, 2022
@crystalenka
Copy link
Member

I have tested this item ✅ successfully on 69dcf1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38723.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 69dcf1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38723.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38723.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 15, 2022
@fancyFranci fancyFranci merged commit 42aad1a into joomla:4.2-dev Sep 15, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 15, 2022
@fancyFranci fancyFranci added this to the Joomla! 4.2.3 milestone Sep 15, 2022
@fancyFranci
Copy link
Contributor

Thanks again!

@brianteeman brianteeman deleted the table_columns branch September 15, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants