Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Subform field uses wrong variables for tooltip with groupByFieldset layout #39848

Closed
HLeithner opened this issue Feb 12, 2023 · 5 comments
Closed

Comments

@HLeithner
Copy link
Member

Steps to reproduce the issue

The layout uses $field to get the id and the description which is not possible because $field is not defined.

$table_head .= '<span class="icon-info-circle" aria-hidden="true" tabindex="0"></span><div role="tooltip" id="tip-' . $field->id . '">' . Text::_($field->description) . '</div>';

Additional comments

I don't use this layout and don't know how to use it just saw this while debugging another thing and just wanted to mention it if someone once to fix it.

@Fedik
Copy link
Member

Fedik commented Feb 12, 2023

yeap that is wrong,
was added by @brianteeman in #26614

There is no field, but fieldset is used.

@Fedik Fedik added the bug label Feb 12, 2023
@brianteeman
Copy link
Contributor

It is used in the core mail domain options

image

@Fedik
Copy link
Member

Fedik commented Feb 12, 2023

Brian it does not use groupByFieldset option there 😉
The bug affects only cases when groupByFieldset="true" is used in subform field xml.

@brianteeman
Copy link
Contributor

I mentioned it for reference only

Fedik added a commit to Fedik/joomla-cms that referenced this issue Feb 20, 2023
@Fedik
Copy link
Member

Fedik commented Feb 20, 2023

Please test #39894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants