[4.0] Subfields - refactor for accessibility etc

[brianteeman]

Fix the layout issue as reported with #26602 and numerous other fixes

summary

• set column widths
• Consistency rename all instances of "sub field" to "sub fields"
• Apply style guide rule for labels
• change the table class and add table id
• replace links with button and remove useless tabindex
• kill the description for the render value field but keep it in the code as a tip (it doesn't need to be repeated on every row)
• Several code style changes
• remove icon-white class from buttons - it was not required and resulted in the icons not being centered

Notes

• It looks to me from the code that I should be able to have repeatable fieldgroups but I couldnt see how
• Really not sure why the fields are in a for each loop when there are only ever the same two. Maybe I am missing something

[Quy]

kill the description for the render value field but keep it in the code as a tip (it doesn't need to be repeated on every row)

Still repeated. See under Global Configuration > Users > Email Domain Options

Would it be better to display it once in the table header instead in a tooltip?

[brianteeman]

Ah I didnt know it was being used by core anywhere. I will review that later and update this PR. Is core using this anywhere else?

Would it be better to display it once in the table header instead in a tooltip?

Yes it would

[brianteeman]

Now that I see the email options page uses this I can see even more issues with the original code - how the heck was this tested and merged

[Quy]

Missing language string under Global Configuration > Users > Email Domain Options.

<caption id="captionTable" class="sr-only">
				PLG_FIELDS_SUBFIELDS_TABLE_CAPTION			</caption>

Is core using this anywhere else?

Under Plugins > System - Redirect, but layout is slightly different. I don't know if there are others.

[AndySDH]

Now that I see the email options page uses this I can see even more issues with the original code - how the heck was this tested and merged

See this: #24711

This was required to be merged by the PR creator for funcionallity wise as over a year of work went into it.

Layout/appearance wise it does indeed still need work.

[brianteeman]

Layout/appearance wise it does indeed still need work.

Not just that as seen from the long list :)

[jduerscheid]

@brianteeman: Please add some testinstructions

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26614.}

[uglyeoin]

I have tested this item ✅ successfully on b8403d7

All seems to work well.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26614.}

[Quy]

I have tested this item ✅ successfully on b8403d7

The repeating description can be addressed in a separate PR.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26614.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26614.}

[wilsonge]

Thanks!

[brianteeman]

Thanks

@Quy can you open an issue for the repeated description please

[AndySDH]

The repeated description in the Email Domain Options page is still an issue in J4 Beta

[wilsonge]

@AndySDH can you please open a fresh issue so it can be tracked