[Code Style] Changes in tag standards: mix #4643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis fails |
|
Just needs https://github.com/joomla/joomla-cms/pull/4643/files#diff-2005bc96db296e43bea8949a653ae346R166 spacing to be fixed. Nothing major |
|
Updating the pulls with the fix for @wilsonge comment and with the change that Michael did in the Sniffs. I guess it should pass now. |
|
Still fails |
|
It's fine, the fail is a bad copy/paste job on one of the tests I was working with. |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull should fix the issue detailed here: joomla/coding-standards#80
I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the mix of latest files to remove the @Package and @subpackage tags.
The rest of the changes were sent in different pulls: #4603, #4625, #4632, #4636, #4637, #4639 and #4617.