[Code Style] Changes in tag standards: Libraries/joomla #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2014
Closed
|
Looks like there are some merge conflicts. Could you update to latest staging? |
|
Updated ^_^ |
Conflicts: libraries/joomla/database/exporter/postgresql.php libraries/joomla/github/package/data.php
|
Thanks! |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull should fix the issue detailed here: joomla/coding-standards#80
I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the libraries/joomla changes.
The components/, modules/, ... are going to be sent in different pulls.
This pull is related to #4603
Note for reviewer: I was going to break this into several pulls but I found easier to do it in different commints, so you can see the changes per commit at https://github.com/joomla/joomla-cms/pull/4617/commits.