Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Style] Changes in tag standards: Libraries/legacy #4625

Closed

Conversation

javigomez
Copy link
Contributor

This pull should fix the issue detailed here: joomla/coding-standards#80

I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the libraries/legacy changes.
The components/, modules/, ... are going to be sent in different pulls.

This pull is related to #4603 and #4617

@infograf768
Copy link
Member

failing

@javigomez
Copy link
Contributor Author

I'm merging current staging that has the change in the sniffers, it should pass travis. Let's see

@nicksavov
Copy link
Contributor

Doesn't pass yet, unfortunately.

@nicksavov nicksavov removed the PBF14 label Oct 17, 2014
@javigomez
Copy link
Contributor Author

mmm I see... just fixed the following error:

FILE: ...me/travis/build/joomla/joomla-cms/libraries/compat/jsonserializable.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 15 | ERROR | @link tag comment indented incorrectly; expected 3 spaces but
    |       | found 5
 16 | ERROR | @since tag comment indented incorrectly; expected 2 spaces but
    |       | found 4

Let's see if travis is now happy ^_^

@Bakual
Copy link
Contributor

Bakual commented Oct 20, 2014

Merged into staging. Thanks!

@javigomez javigomez closed this in edb787e Oct 20, 2014
@Bakual Bakual added this to the Joomla! 3.3.7 milestone Oct 20, 2014
@mbabker mbabker modified the milestones: Joomla! 3.3.7, Joomla! 3.4.0 Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants