New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fixes #4763 where adding space created duplicate viewlevels #4776
Conversation
i just tested this and it works indeed with your patch |
We have more than 2 successful test, moving to RTC . |
FILE: ...d/joomla/joomla-cms/administrator/components/com_users/models/level.php FOUND 1 ERROR(S) AFFECTING 1 LINE(S) 216 | ERROR | Whitespace found at end of line |
Also, I suggest to use, instead of trim() the new filter which takes also care of multibytes spaces (Asian space), i.e
use
To test here is a multibyte space between both multi |
This fixes #4763 where adding space created duplicate users
Thanks! |
@aDaneInSpain @infograf768 Do you think we should backport it to 2.5.x? |
The new filtering method does not exist in 2.5.x, so we should use trim(). |
.#### Steps to reproduce the issue
Expected result
Duplicate access levels should not be added.
Actual result
Duplicate access levels are added successfully.
System information (as much as possible)
PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0
Additional comments