Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_tags missing a global float option #6511

Closed
modernmagic opened this issue Mar 20, 2015 · 7 comments
Closed

com_tags missing a global float option #6511

modernmagic opened this issue Mar 20, 2015 · 7 comments

Comments

@modernmagic
Copy link
Contributor

modernmagic commented Mar 20, 2015

This does not appear to be working. I am still trying to figure out why.

float_intro)) ? $this->params->get('float_intro') : $images->float_intro; ?>
            <div class="pull-<?php echo htmlspecialchars($imgfloat); ?> item-image">

I also believe com tags / options should have a global default for the floats.

@brianteeman
Copy link
Contributor

What is not working? What are you expecting to happen? What actually happens? Where are you using this code?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6511.

@modernmagic
Copy link
Contributor Author

Sorry for the noob posting.

  1. There does not appear to be a "global setting" for the tag image float even though it is an option in the dropdown menu.
    screen shot 2015-03-23 at 10 11 27 am
  2. Since there is no "Global settings", that options does not apply a direction.
  3. That code was copied from components/com_tags/views/tags/tmpl/default_items.php

Again sorry, just trying to help but I am not a developer, but more of an implementer/agency.

@brianteeman
Copy link
Contributor

Thanks for clarifying things and reporting the issue. The more information
you provide the easier it is for people to see what isnt working and what
needs to be done

On 23 March 2015 at 17:52, modernmagic notifications@github.com wrote:

Sorry for the noob posting.

  1. There does not appear to be a "global setting" for the tag image
    float even though it is an option in the dropdown menu. [image: screen
    shot 2015-03-23 at 10 11 27 am]
    https://cloud.githubusercontent.com/assets/2553410/6786494/db3d1f58-d149-11e4-9e2f-4f230d4d8b1c.png
  2. Since there is no "Global settings", that options does not apply a
    direction.
  3. That code was copied from
    components/com_tags/views/tags/tmpl/default_items.php

Again sorry, just trying to help but I am not a developer, but more of an
implementer/agency.


Reply to this email directly or view it on GitHub
#6511 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@locii
Copy link

locii commented Mar 25, 2015

Hi Jeff,

Thats possibly a template issue. Does it happen with Protostar as well as the template you are using?

@modernmagic
Copy link
Contributor Author

Since there is no Global float settings for images, it does not appear that this would be a template issue.
screen shot 2015-03-25 at 9 18 02 am

But, yes if I switch to protostar the images do not float unless each tag is set to float in its own "Edit Tag/Images options".

@modernmagic modernmagic changed the title com_tags float not working com_tags missing a global float option Mar 25, 2015
@modernmagic
Copy link
Contributor Author

I see that I have created some confusion with a poor issue title. I have changed it to "com_tags missing a global float option #6511"

@brianteeman
Copy link
Contributor

Closing this really old issue with a PR #11401


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants