Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect option in tag item image float #11401

Merged
merged 1 commit into from
Aug 13, 2016
Merged

Incorrect option in tag item image float #11401

merged 1 commit into from
Aug 13, 2016

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Aug 2, 2016

Pull Request for Issue #6511 .

Summary of Changes

There are two image fields for a tag and they have a float option. Probably due to a copy past error they offer a Global option but there is no where to set a global value.

This PR changes the meaningless use global string with a select an option string

AFTER PR

v dt

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on b04bc9c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11401.

@MATsxm
Copy link

MATsxm commented Aug 2, 2016

I have tested this item ✅ successfully on b04bc9c

Able to reproduce, then #11401 works as described

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11401.

@brianteeman
Copy link
Contributor Author

Rtc thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11401.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2016
@brianteeman brianteeman added this to the Joomla 3.6.2 milestone Aug 2, 2016
@rdeutz rdeutz merged commit 94d6c06 into joomla:staging Aug 13, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
@brianteeman brianteeman deleted the tagfloat branch August 13, 2016 17:56
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants