Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
While reviewing the PR #6893, I see that JTable publish method has a bug. If you create a JTable object, load a record from using load() method, then call publish() method, you will see some notices and the record won't be published.
To see it, try to run this code somewhere on your Joomla site:
After running the code above, we should have contact with ID = 1 published. However, the published status of the record not changed and you will see notices like this:
It causes by a typo in the code, I think. And this PR fix it.
Testing instruction