Clean up the published method.

[roland-d]

Goal

The goal of this pull request is to clean up some code that I found is duplicate and could be improved after checking #3189. This completely removes the publish() override for the JTableContent class as it is obsolete with the update.

How to test

1. Go to the article manager:
   administrator/index.php?option=com_content&view=articles
2. Unpublish an article and check that it works
3. Publish an article and check that it works
4. Apply this pull request
5. Unpublish an article and check that it works
6. Publish an article and check that it works

[infograf768]

Looks like Travis is not happy.

[roland-d]

@infograf768 For good reason Travis wasn't happy, there was an issue indeed but is solved now. Travis is happy 😄

[joomdonation]

I think type casting is not needed here. It will causes incorrect behavior in case we call publish method of a JTable object (without passing $pks variable, just want to publish the current loaded record).

[roland-d]

We should be typecasting to an array because the code expects an array as is mentioned in the docblock.

[joomdonation]

It can be null (If not set the instance property value is used). Please see this sample code:

require_once JPATH_ADMINISTRATOR.'/components/com_contact/tables/contact.php';
$row = JTable::getInstance('Contact', 'ContactTable');
$row->load(1);
$row->publish();

In this case, the value of $pks value is null, and the current record should be published (It doesn't work now because of a typo in the class and I made a separate PR to fix it).

[alataknet]

@test success i published and unpublished an article successfully

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.}

[Dylis]

@test - Success. Patch tested with article set both to registred and public display.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.}

[zero-24]

RTC. Thanks!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6893.}

[wilsonge]

Merged - Thanks!

[joomdonation]

Hmm. This PR is still having issue which I pointed above. I don't think it is not good to be merged yet :(.

[roland-d]

@joomdonation Correct, I will create a new PR for that.