Fixed primary key null not being respected #6914
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If no primary key value is passed to the publish method it is now not being respected as it is turned into an array, the loaded state is not being used as should. This PR fixes this issue introduced in #6893
Test instructions
Apply pull request Fix JTable publish method error #6900 first
Add the code below to the file administrator/component/com_cpanel/cpanel.php after line 10.
This will show the problem as we first unpublish the record and then publish it.
Load the administrator control panel and it shows Published: 0. This is wrong because we just published the record.
Apply the patch
Load the administrator control panel and it shows Published: 1. This is correct because we just published the record.
Testing finished