Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile enable offline login page #7977

Closed
osignell opened this issue Sep 29, 2015 · 9 comments
Closed

Mobile enable offline login page #7977

osignell opened this issue Sep 29, 2015 · 9 comments

Comments

@osignell
Copy link
Contributor

Steps to reproduce the issue

Put a site offline, open the page with a mobile phone or similar device

Expected result

Usable login screen is shown

Actual result

Zoomed out login screen is shown, requires user to manually zoom in before logging in.

System information (as much as possible)

Additional comments

Can be fixed by including:

<meta name="viewport" content="width=device-width, initial-scale=1.0" />

in the section of the /templates/system/offline.php file

@anibalsanchez
Copy link
Contributor

In the same line, it would be great to add autocorrect=off and autocapitalize=none in username field.

In my sites, I have added this script in login view:

$document->addScriptDeclaration('jQuery(document).ready(function(){
    jQuery("#username").attr("autocorrect", "off").attr("autocapitalize", "none");
});');

@brianteeman
Copy link
Contributor

Which mobile browser are you using? The default behaviour when initial-scale
is not defined is for it to be 1.0

On 29 September 2015 at 09:49, Anibal Sanchez notifications@github.com
wrote:

In the same line, it would be great to add autocorrect=off and
autocapitalize=none in username field.

In my sites, I have added this script in login view:

$document->addScriptDeclaration('jQuery(document).ready(function(){
jQuery("#username").attr("autocorrect", "off").attr("autocapitalize", "none");
});');


Reply to this email directly or view it on GitHub
#7977 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@osignell
Copy link
Contributor Author

The problem is visible on an iPhone 6 with both the built-in Safari browser and with Google Chrome. In both cases the login screen is shown correctly if initial-scale is explicitly set to 1.0.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7977.

@brianteeman
Copy link
Contributor

Tested on iphone5 and android and cannot replicate.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7977.

@justinherrin
Copy link
Contributor

I can see the issue on iPhone 5S using both Safari and Chrome apps.

@justinherrin
Copy link
Contributor

I will work on a PR to help make the offline page a bit more mobile friendly. Stay tuned

@brianteeman
Copy link
Contributor

Obviously there must be a non-standard default setting on that phone. No
harm in making the update though - thanks

On 29 September 2015 at 15:16, Justin Herrin notifications@github.com
wrote:

I will work on a PR to help make the offline page a bit more mobile
friendly. Stay tuned


Reply to this email directly or view it on GitHub
#7977 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@justinherrin
Copy link
Contributor

PR #7981 has been created and is ready for testing

@brianteeman
Copy link
Contributor

Sorry I completely misread the original report. I thought you were saying you had to zoom out in order to use it and not the opposite. Must not reply before I;ve had a coffee in future.

Closing as we have a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants