Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Offline Page Mobile Friendly #7981

Merged
merged 2 commits into from
Oct 1, 2015
Merged

Conversation

justinherrin
Copy link
Contributor

This PR is for Issue #7977 and will make the default Offline page be more mobile friendly. I updated the offline template PHP and CSS files. Here are some before and after images...

Mobile View: Before

offline-mobile-before

Mobile View: After

offline-mobile-after

Desktop View: Before

offline-desktop-before

Desktop View: After

offline-desktop-after

@infograf768
Copy link
Member

Works fine on desktop.

@zero-24
Copy link
Contributor

zero-24 commented Sep 30, 2015

I have tested this item ✅ successfully on 4d60f8c
Works good here. Thanks @justinherrin just tested on desktop and WP ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7981.

@zero-24
Copy link
Contributor

zero-24 commented Sep 30, 2015

RTC based on tests. Thanks @justinherrin


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7981.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 30, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.5 milestone Sep 30, 2015
rdeutz added a commit that referenced this pull request Oct 1, 2015
Make Offline Page Mobile Friendly
@rdeutz rdeutz merged commit 153d52c into joomla:staging Oct 1, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 1, 2015
@justinherrin justinherrin deleted the patch-2 branch October 1, 2015 20:37
@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants