Removing root path from the entire output #9280

Radek-Suski · 2016-03-02T10:14:07Z

Pull Request for Issue #9252

Summary of Changes

Removing root path from the entire output

Testing Instructions

Check if the report contains the path to Joomla! installation

brianteeman · 2016-03-02T10:39:51Z

administrator/components/com_admin/views/sysinfo/view.json.php

@@ -39,7 +39,7 @@ public function display($tpl = null)

 		$data = $this->getLayoutData();

-		echo json_encode($data);
+		echo str_replace(JPATH_ROOT, '', json_encode($data));


I think it would be better as
echo str_replace(JPATH_ROOT, 'xxxxxx', json_encode($data));

So that it is clear there is something hidden in the output

brianteeman · 2016-03-02T10:42:51Z

@Radek-Suski can you update this as per my comments so it is clear something has been removed from the output

Ignore the Travis failures they are unrelated

…ding to Brian Teeman's comments

Radek-Suski · 2016-03-02T10:51:59Z

Done

brianteeman · 2016-03-02T11:04:30Z

Works fine for plain text

Maybe my suggested code was wrong for json as the json still shows the full path
eg

{"writable":false,"message":""},"cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"administrator/cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"/Applications/MAMP/htdocs/joomla-cms-staging/logs":{"writable":true,"message":"COM_ADMIN_LOG_DIRECTORY"},"/Applications/MAMP/htdocs/joomla-cms-staging/tmp":{"writable":true,"message":"COM_ADMIN_TEMP_DIRECTORY"}},"phpInfo":

Radek-Suski · 2016-03-02T11:15:32Z

No, I missed a point. Give me few hours. I need to go out for a moment

…telly in all directories paths

wilsonge · 2016-03-02T22:04:55Z

Bump Radek :)

Radek-Suski · 2016-03-02T22:25:33Z

@wilsonge I fixed it already

andrepereiradasilva · 2016-03-02T22:55:51Z

@Radek-Suski one full path remains in the json: php open_basedir (if configured on the server), in txt is ok xxxxxxxx but in json is there

And there is also the /etc paths (openssl default config path, opcache blacklist path, for instance).
Don't know if they are a part of this PR though.

brianteeman · 2016-03-02T23:53:15Z

@Radek-Suski Removing it completely (web and download) is not a good solution as it is useful for people to know this

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

brianteeman · 2016-03-02T23:53:35Z

I have tested this item 🔴 unsuccessfully on 1085f72

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

N6REJ · 2016-03-03T01:02:36Z

What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
Bear

On 3/2/2016 17:53, Brian Teeman wrote:

@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this

_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.

—
Reply to this email directly or view it on GitHub
#9280 (comment).

brianteeman · 2016-03-03T01:36:01Z

None at all
On 3 Mar 2016 1:02 am, "Bear" notifications@github.com wrote:

What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
Bear

On 3/2/2016 17:53, Brian Teeman wrote:

@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this

_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.

—
Reply to this email directly or view it on GitHub
#9280 (comment).

—
Reply to this email directly or view it on GitHub
#9280 (comment).

Radek-Suski · 2016-03-03T07:19:15Z

@brianteeman we are removing it from all other paths so it would it doesn't make sense to make an exception for two paths only.
open_basedir would be hard to remove because it is not part of the Joomla! configuration.
I tested the solution and it worked for me. What doesn't work for you @brianteeman?

brianteeman · 2016-03-03T08:51:43Z

@Radek-Suski We are ONLY removing the full path form the text and the json NOT the web
Example is Session Save Path which is displayed in full in the web interface but is obfuscated to session.save_path: xxxxxx in the json and text download

This last update from you removes the full path for logs and tmp folder in the folder permissions tab from the text, json AND web views it should not be removed from the web view.

Hope that makes sense

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

brianteeman · 2016-03-03T09:01:26Z

@andrepereiradasilva
I tested open_basedir and it is crrectly being removed from the text and json if it is set and still present in the web interface
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/models/sysinfo.php#L113

Not sure what @radek_suski meant about it not being something we can remove - he must need more coffee - as he wrote the code already

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

Radek-Suski · 2016-03-03T09:33:45Z

Ok, now I am a bit confused. What is a "web view"?

brianteeman · 2016-03-03T09:44:17Z

The bit you can see in your web browser
On 3 Mar 2016 9:33 am, "Radek Suski" notifications@github.com wrote:

Ok, now I am a bit confused. What is a "web view"?

—
Reply to this email directly or view it on GitHub
#9280 (comment).

joomla-cms-bot · 2016-03-03T10:20:49Z

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

joomla-cms-bot · 2016-03-03T10:39:54Z

This PR has received new commits.

CC: @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

brianteeman · 2016-03-03T10:40:09Z

Lets try testing it as well ;)

The txt and the json have

Warning: strstr() expects parameter 1 to be string, array given in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_admin/models/sysinfo.php on line 186

The web now just says

log (Log folder) Writable
tmp (Temp folder) Writable

The web should be as it was before

/Applications/MAMP/htdocs/joomla-cms-staging/logs (Log folder) Writable
/Applications/MAMP/htdocs/joomla-cms-staging/tmp (Temp folder) Writable

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

richard67 · 2016-03-03T13:23:09Z

Even worse now as before, as far as I could see log and temp dirs are also back with full path in json.

joomla-cms-bot · 2016-03-03T13:24:44Z

This PR has received new commits.

CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

andrepereiradasilva · 2016-03-03T13:28:54Z

I have tested this item ✅ successfully on 4d4e933

for me is ok
i would advice removing /etc paths too, but in another PR

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

richard67 · 2016-03-03T13:43:16Z

I have tested this item ✅ successfully on 4d4e933

Tested with success, now both text and json format export files do not contain abolute paths anymore, also not for open_basedir, but in the backend sytem information views (html views) they still are shown as it should be.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

joomla-cms-bot · 2016-03-03T13:52:07Z

This PR has received new commits.

CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

anibalsanchez · 2016-03-03T14:18:23Z

I have tested this item ✅ successfully on 60c327c

Test Ok. No paths.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

richard67 · 2016-03-03T15:15:23Z

@Radek-Suski Shall we wait for further CS fixes for Travis? Or shall we test now? Let us know pls.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

Radek-Suski · 2016-03-03T15:16:42Z

Feel free to test. I have no time at the moment to pleasure Travis ;)

richard67 · 2016-03-03T15:18:18Z

OK. Was not your CS mistakes anyway.

wilsonge · 2016-03-03T15:18:26Z

It's fine - I can fix travis when i merge :)

Radek-Suski · 2016-03-03T15:19:55Z

Thanks @wilsonge. You've a beer in Barcelona 💃

andrepereiradasilva · 2016-03-03T15:21:55Z

it's already tested successfully several times, so can be merged IMHO

wilsonge · 2016-03-03T15:22:24Z

RTC

wilsonge · 2016-03-03T15:22:34Z

Will merge when I get home tonight.

richard67 · 2016-03-03T15:23:13Z

I have tested this item ✅ successfully on 60c327c

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

richard67 · 2016-03-03T15:24:23Z

@wilsonge It seems joomla-cms-bot does not like you 👅 Maybe it's better with 2 good tests? Just tested with success.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

1apweb · 2016-03-03T15:37:34Z

I have tested this item ✅ successfully on 60c327c

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

brianteeman · 2016-03-03T19:30:30Z

RTC (again)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.}

Removing root path from the entire output

92a5b64

joomla-cms-bot added the PR-staging label Mar 2, 2016

brianteeman mentioned this pull request Mar 2, 2016

Remove some absolute paths from sysinfo download #9274

Closed

wilsonge added the 3.5.0-blocker label Mar 2, 2016

brianteeman reviewed Mar 2, 2016
View reviewed changes

Removing root path from the entire output - changed repacement acccor…

95d377c

…ding to Brian Teeman's comments

Fixed JSON output. Removed the xxxx because we are removing it comple…

1085f72

…telly in all directories paths

let's try to do this more logically

2b394ef

oh for gods' sakegit push

7ccf27d

adding an exception for web view

4bde079

second 'open_basedir'

4d4e933

Travis

60c327c

wilsonge added the RTC This Pull Request is Ready To Commit label Mar 3, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2016

wilsonge added the RTC This Pull Request is Ready To Commit label Mar 3, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2016

wilsonge added the RTC This Pull Request is Ready To Commit label Mar 3, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2016

wilsonge closed this in 8159473 Mar 3, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2016

wilsonge removed the 3.5.0-blocker label Mar 6, 2016

Removing root path from the entire output #9280

Removing root path from the entire output #9280

Conversation

Radek-Suski commented Mar 2, 2016

Summary of Changes

Testing Instructions

brianteeman Mar 2, 2016

Choose a reason for hiding this comment

brianteeman commented Mar 2, 2016

Radek-Suski commented Mar 2, 2016

brianteeman commented Mar 2, 2016

Radek-Suski commented Mar 2, 2016

wilsonge commented Mar 2, 2016

Radek-Suski commented Mar 2, 2016

andrepereiradasilva commented Mar 2, 2016

brianteeman commented Mar 2, 2016

brianteeman commented Mar 2, 2016

N6REJ commented Mar 3, 2016

brianteeman commented Mar 3, 2016

Radek-Suski commented Mar 3, 2016

brianteeman commented Mar 3, 2016

brianteeman commented Mar 3, 2016

Radek-Suski commented Mar 3, 2016

brianteeman commented Mar 3, 2016

joomla-cms-bot commented Mar 3, 2016

joomla-cms-bot commented Mar 3, 2016

brianteeman commented Mar 3, 2016

richard67 commented Mar 3, 2016

joomla-cms-bot commented Mar 3, 2016

andrepereiradasilva commented Mar 3, 2016

richard67 commented Mar 3, 2016

joomla-cms-bot commented Mar 3, 2016

anibalsanchez commented Mar 3, 2016

richard67 commented Mar 3, 2016

Radek-Suski commented Mar 3, 2016

richard67 commented Mar 3, 2016

wilsonge commented Mar 3, 2016

Radek-Suski commented Mar 3, 2016

andrepereiradasilva commented Mar 3, 2016

wilsonge commented Mar 3, 2016

wilsonge commented Mar 3, 2016

richard67 commented Mar 3, 2016

richard67 commented Mar 3, 2016

1apweb commented Mar 3, 2016

brianteeman commented Mar 3, 2016