Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra Tinymce code #9341

Merged
merged 3 commits into from Mar 8, 2016
Merged

remove extra Tinymce code #9341

merged 3 commits into from Mar 8, 2016

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue # 9339.

Summary of Changes

Remove duplicated code icon

Testing Instructions

Check in the advanced AND extended modes of tinmyce and you will see two code icons. One after the image icon and one at the very end

This PR removes the second instance

@AlexRed
Copy link
Contributor

AlexRed commented Mar 8, 2016

I have tested this item ✅ successfully on 15a4c81


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@brianteeman brianteeman changed the title remove extra Tinymce code remove extra Tinymce code Mar 8, 2016
@stellainformatica
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 15a4c81

The PR solves the issue for extended funcionality, but in this way in Advanced funcionality there is no more <> button.
If you change just the line 890, then you'll have the expected result.
I would suggest not to put the code button at the end, but in the middle, in this way

toolbar1: "$toolbar1 | code | $toolbar5 ",


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@1apweb
Copy link

1apweb commented Mar 8, 2016

I have tested this item ✅ successfully on 15a4c81


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @1apweb, @AlexRed, @stellainformatica


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@stellainformatica
Copy link
Contributor

I have tested this item ✅ successfully on 655d7fa


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 655d7fa

Tested in both advanced and extended mode that in both cases there is 1 icon "<>" for source code insert shown after the icon for image insert.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@brianteeman
Copy link
Contributor Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 8, 2016
wilsonge added a commit that referenced this pull request Mar 8, 2016
@wilsonge wilsonge merged commit a7ce3b8 into joomla:staging Mar 8, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Mar 8, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 8, 2016
@wilsonge
Copy link
Contributor

wilsonge commented Mar 8, 2016

Thanks Brian!

@brianteeman brianteeman deleted the tinymce-code branch March 8, 2016 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants