Redo PR #9379 (fix batch tooltip when mod multilanguage status enabled) #9944

cyrezdev · 2016-04-15T23:55:53Z

EDIT: REDO PR #9379
This PR has fixed tooltip not visible in batch modal.
But tooltip are not displayed (since 3.5.0 or before...) if module multilanguage status is enabled

Testing Instructions

Open batch modals (articles, menus...)
hover the labels and be sure the tooltip is always visible (as describe in this issue [Regression] Tooltips not visible in batch modal #9363 screenshots)
Test with and without admin module multilanguage status enabled

Missing change of PR joomla#9379

andrepereiradasilva · 2016-04-16T11:57:26Z

hum ... for me the tooltip doesn't exist with or without the PR (using latest staging on chrome).

cyrezdev · 2016-04-16T12:50:03Z

@andrepereiradasilva just tested with latest staging and fresh install on Chrome (mac), and i have the label tooltip:

Note: with or without patch, tooltip works for me...

andrepereiradasilva · 2016-04-16T16:27:52Z

ok, so clearly is something on my part.

andrepereiradasilva · 2016-04-16T20:31:09Z

i also tested with firefox and same problem. no tooltips in batch modals.

Either way i have some modals where the tooltip exists and it's croped (the article select modal in single article menu item), so i tested your PR in that one.

And ... it's still croped.

cyrezdev · 2016-04-17T16:04:22Z

@andrepereiradasilva there's a misunderstanding of this PR... ;-)
And, this is not related to any tooltip outside of the batch modals!
In Batch modal, it's not using jform fields from components, but layouts/joomla/html/batch to render field, where tooltip has modalTooltip class as handler, and not hasTooltip
Your issue with single article select is not related to batch issue, but... a fix could be done for the issue your report, i think in the layout main for BS modal (could be another PR i could do later... ;-) )

About this PR
This one is not a fix, but additionnal change to a previous PR, to prevent possible future issue.

To Sum-up Batch modal tooltip issue

Issue with batch modal tooltip reported here: [Regression] Tooltips not visible in batch modal #9363
Fix for the layouts/html/batch/language.php concerning tooltip on first layout field here: FIX #9363 Tooltips not visible in batch modal #9379
And successfull tested and merged in 3.5.0

Information on Bootstrap tooltip

Joomla is using hasTooltip as class handler for BS tooltip (previously mootools) (of course, i think you already know that ;-) )
hasTooltip class is used in all joomla component views
hasTooltip (BS tooltip) container is set by default on body BUT in a modal, this will not show the tooltip, because modal has an higher z-index than the body (known issue of BS modal... again...)
in a BS modal, we should set the container for the tooltip on an element included inside the modal. Issue was just this one was set on .modal-body and so were cropped before as it's better to set container to .modal to include the header of the modal window.

Why it's different in Batch modals

Batch modals used layouts form fields.
In those layouts, the class name for tooltip is not hasTooltip, but modalTooltip (this is good!)
in each layout where we use a BS tooltip, as included inside a modal, we need to set the container to .modal

Why this PR?
I did it in language field batch layout, and it was working as the first field loaded in each batch modal. My error was just to not do the same change for access, user and tag (in case one day, language is not the first to be loaded (setting the container), or someone create an override with a different ordering...)

@andrepereiradasilva so, in your testing, you should have the tooltip in batch modals. If you don't have any tooltip on labels hover, there's another issue... Do you have tested on a fresh staging install ?
So, if you don't see any tooltip in batch modal, could you check you have the following script declaration in you page head:

jQuery(document).ready(function(){
    jQuery('.modalTooltip').tooltip({"html": true,"container": ".modal"});
});

And not something else set for .modalTooltip ?...

andrepereiradasilva · 2016-04-17T16:18:27Z

ok, only for batch modals then :)

in your testing, you should have the tooltip in batch modals. If you don't have any tooltip on labels hover, there's another issue... Do you have tested on a fresh staging install ?

I have a clean staging install. tested on windows chrome and firefox and no tooltip in batch modals.

So, if you don't see any tooltip in batch modal, could you check you have the following script declaration in you page head:

Before and after the PR i have:

jQuery(document).ready(function(){
    jQuery('.hasTooltip').tooltip({"html": true,"container": "body"});
});
[...]
jQuery(document).ready(function(){
    jQuery('#filter_search').tooltip({"html": true,"title": "Search title or alias. Prefix with ID: to search for an article ID.","container": "body"});
});
jQuery(document).ready(function(){
    jQuery('.modalTooltip').tooltip({"html": true,"container": ".modal"});
});

andrepereiradasilva · 2016-04-17T16:27:17Z

i think the problem is related to the "Multilingual Status" link z-index in admin status bar (if i remove the status bar i can see the tooltips!).

See https://github.com/joomla/joomla-cms/blob/staging/administrator/modules/mod_multilangstatus/tmpl/default.php#L15

So the problem clearly doesn't came from your PR

cyrezdev · 2016-04-17T16:27:49Z

@andrepereiradasilva You will drive me crazy! ;-)

So, no need to test with this PR, staging shoudl work... then i don't know why it does not work for you as it should (feedback from other users would be welcome especially on windows, as the issue is maybe not related to the batch modal tooltip directly...)

What do you have when you hover labels in batch modals? nothing at all? error in console ?

Could you do a test on 3.5.1 stable about batch modals? (or 3.5.0)

andrepereiradasilva · 2016-04-17T16:28:15Z

@JoomliC please read my previous updated comment

andrepereiradasilva · 2016-04-17T16:29:40Z

Confirmed: Disabled mod_multilanguage admin module and finally i can see the tooltip!!

I guess both of us where right ;)

andrepereiradasilva · 2016-04-17T16:33:13Z

sorry for all of this, but i really couldn't see any tooltip ... enable mod_multilanguage admin module and you'll see what i saw: no tooltip at all.

I will now test your PR with the mod_multilanguage admin module disabled.

cyrezdev · 2016-04-17T16:33:33Z

i think the problem is related to the "Multilingual Status" link z-index in admin status bar (if i remove the status bar i can see the tooltips!).

Great!
You've found it!
So, the z-index for module is too hight for the modal....
Now, this would need another PR, to fix it, as the issue is already there with 3.5.1 !

In the same time, maybe the modal z-index should be increase, to be sure the "dark" background is hover all the page contents... What's you opinion ?

andrepereiradasilva · 2016-04-17T16:34:40Z

i think the mod_multilanguage needs to be corrected.

You can see also that with that module enabled the admin status bar is visible!! in all modals.

cyrezdev · 2016-04-17T16:36:50Z

@andrepereiradasilva we post in the same time ;-)

The issue you found is not related to this PR, but to a bug already there! (confirmed with 3.5.1)

i think the mod_multilanguage needs to be corrected.

Exactly what i see now too! ;-)
So maybe first to check why this z-index was set to this module ?...

andrepereiradasilva · 2016-04-17T16:37:30Z

So maybe first to check why this z-index was set to this module ?...

because the link opens a modal :)

andrepereiradasilva · 2016-04-17T16:39:40Z

I have tested this item ✅ successfully on ecd1002

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

cyrezdev · 2016-04-17T16:42:49Z

Ok, but miss the reason for this 61eb22d#diff-9c08ca434f4f64bc6d36d803d6f174afR16

Maybe to keep it visible when the modal is open, but.. not sure really needed... (need your lights @dgt41 ;-) )

cyrezdev · 2016-04-17T16:55:51Z

@andrepereiradasilva seems that with or without the z-index set in module multi-languages, change nothing in tooltip conflict... and indeed, i see why this one is used.

andrepereiradasilva · 2016-04-17T16:59:19Z

ok. so, we don't know what it is exactly, but it's module multi-languages fault for sure :)

andrepereiradasilva · 2016-04-17T17:30:44Z

i think i found a way to solve the mod_multilangue issue. will make a PR

andrepereiradasilva · 2016-04-17T17:33:37Z

Please test #9958

infograf768 · 2016-04-17T18:30:27Z

Hmm
even with @andrepereiradasilva patch, I do not get any tip in the batch modals, also for language.

andrepereiradasilva · 2016-04-17T18:36:12Z

@infograf768 yes that's mod_multilanguage modal code fault.

cyrezdev · 2016-04-17T18:54:42Z

@andrepereiradasilva yes, just tested, and fix issue with bottom bar index (better looking!).
ANd yes, unfortunately the issue with tooltip (note: already there in 3.5.1 stable when module multi-languages enabled. note for @infograf768 : not related to this PR, which is the missing change for a PR you already have tested: #9379 ;-) )
So, need to be tested only when module multi-language is disabled, because issue is not the same, and not related to the current change of this PR ;-)

But for sure, a fix to be found for module multi-languages... :-|

joomla-cms-bot · 2016-04-17T23:05:44Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

joomla-cms-bot · 2016-04-17T23:06:17Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

joomla-cms-bot · 2016-04-17T23:06:58Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

joomla-cms-bot · 2016-04-17T23:08:34Z

This PR has received new commits.

CC: @andrepereiradasilva

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

andrepereiradasilva · 2016-04-17T23:24:24Z

I have tested this item ✅ successfully on 0c1e34a

nice, now the batch modal tooltips work with or without multilanguage status admin module.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

cyrezdev · 2016-04-17T23:34:39Z

@andrepereiradasilva so, i found a way to fix tooltip with module multilanguage status enabled (due to maybe a class conflict...)

So, as all Batch button use "collapseModal" as selector, i have directly set #collapseModal as tooltip container, as in all batch modals, it is the ID of the div modal.
It was working too with container set to div .modal in place of .modal, but i think was better to use directly the unique id of the batch modal.

EDIT: @andrepereiradasilva you really post so fast, i don't have yet time to finish my message ;-)
Thanks for testing, and in the same day, finding and solving another issue! 👍 (in fact 2 issues on mod multilanguage: #9958 (comment) !!!)

@infograf768 the PR is updated, now included a fix too for batch modals tooltip with or without module multilanguage status enabled ;-)

andrepereiradasilva · 2016-04-17T23:55:47Z

oh, and not related to this PR, but related to tooltips on modals in the croped tooltips in article select ...

the problem must be the fact that the tooltip is reaching the iframe boundaries, so IMO we have two options:

not use iframes at all: ie, load the content via ajax and dump it. would also be good for accessibility, but probably a lot of css work
make the tooltip render on bottom instead of top of the labels on this component iframes: don't know if this is simple or not . i guess data-placement="bottom" could be used for that

infograf768 · 2016-04-18T09:16:24Z

I have tested this item ✅ successfully on 0c1e34a

Works fine now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

infograf768 · 2016-04-18T09:16:55Z

RTC. Thanks. Can go in 3.5.2

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9944.}

infograf768 · 2016-04-18T09:19:13Z

@andrepereiradasilva

I don't have your issue here:

andrepereiradasilva · 2016-04-18T11:46:16Z

@infograf768 i guess some part depends on browser rendering.
Then go to "Components" -> "Messaging" and click the "My Settings" toolbar button, then try the tooltip in "Local Inbox" label. the issue is the same.

infograf768 · 2016-04-18T13:06:20Z

I confirm the issue in that case (Firefox Macintosh)

cyrezdev · 2016-04-18T15:11:44Z

the problem must be the fact that the tooltip is reaching the iframe boundaries, so IMO we have two options: not use iframes at all: ie, load the content via ajax and dump it. would also be good for accessibility, but probably a lot of css work make the tooltip render on bottom instead of top of the labels on this component iframes: don't know if this is simple or not . i guess data-placement="bottom" could be used for that

@andrepereiradasilva Yes, iframe issue with BS tooltip.
Another possibility: back using mootools tooltips (joke!) ;-)

Your second option, even if not the best (as definitely an "auto" mode placement is missing in BS2... (but is included in BS3)) is the way to go until iframe are maybe replace little by little by modal body as a layout of the view.
Bottom placement could be set in all view loaded as an iframe.
So, when a little more time, i will see to do a full list of all modals using iframe, in order to check the best way to go for now...
In the same time, if you could list all modals where the issue is today (as on mac, seems that we have less modal with issue than on windows... i think that @infograf768 is on mac too, as i don't have issue with select article, excepted 2 or 3 pixels missing on top of id tooltip ;-) ), i may be able to add a quick valid fix for next version. (but the more i work on BS modals, the more i find many places where some changes could be done to improve all that!).

So, placement bottom for tooltip needed today for:

menu item > article type > select article
components > messaging > settings
...

cyrezdev · 2016-04-18T15:30:21Z

@andrepereiradasilva do you have the issue with versions too (2 last buttons Keep On/Off and Delete) ?
note: i will prepare a PR for known modals using iframe, with tooltip top placement issue, but with other issue too as versions is just because the placement is missing for last 2 buttons ;-)

andrepereiradasilva · 2016-04-18T15:34:42Z

@JoomliC no not that one because the title is repeated (what?) and with that moves the buttons down so it doesn't reach the iframe boundaries.

Update: actually it reaches it by some pixels as you can see in the picture.

cyrezdev · 2016-04-18T18:02:36Z

@andrepereiradasilva yes, i saw that about title, and other things too, and will do a PR for a better rendering of Versions html modal ;-)

About tooltip inside iframe, i'm testing a way to fix it without having to edit all related views... But if i don't find the solution, i will do the PR to fix all modal views (which works well indeed with just changing one line!) ;-)

cyrezdev · 2016-04-19T15:46:47Z

@andrepereiradasilva and @infograf768, first PR for modal iframe issue: #9991
About com_messages Settings button ;-)

cyrezdev added 3 commits April 16, 2016 01:46

Change modalTooltip container .modal-body to .modal

bed5eb5

Missing change of PR joomla#9379

Change modalTooltip container .modal-body to .modal

42fabae

Missing change of PR joomla#9379

Change modalTooltip container .modal-body to .modal

ecd1002

Missing change of PR joomla#9379

joomla-cms-bot added the PR-staging label Apr 15, 2016

Fix batch modalTooltip when mod Multilanguages status enabled

2d0c4d3

Fix batch modalTooltip when mod Multilanguages status enabled

ca81f6c

Fix batch modalTooltip when mod Multilanguages status enabled

0c1e34a

cyrezdev changed the title ~~Missing changes of PR #9379 (already merged)~~ Redo PR #9379 (fix batch tooltip when mod multilanguages enabled) Apr 17, 2016

cyrezdev changed the title ~~Redo PR #9379 (fix batch tooltip when mod multilanguages enabled)~~ Redo PR #9379 (fix batch tooltip when mod multilanguage status enabled) Apr 17, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 18, 2016

rdeutz added this to the Joomla 3.5.2 milestone Apr 18, 2016

rdeutz merged commit 6898ad8 into joomla:staging Apr 18, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 18, 2016

cyrezdev mentioned this pull request Apr 19, 2016

Hidden tooltip #9832

Closed

rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016

cyrezdev mentioned this pull request May 4, 2016

Add bootstrap tooltip extended: 4 extra positions and RTL support #10237

Merged

Redo PR #9379 (fix batch tooltip when mod multilanguage status enabled) #9944

Redo PR #9379 (fix batch tooltip when mod multilanguage status enabled) #9944

Conversation

cyrezdev commented Apr 15, 2016 • edited

Testing Instructions

andrepereiradasilva commented Apr 16, 2016

cyrezdev commented Apr 16, 2016 • edited

andrepereiradasilva commented Apr 16, 2016

andrepereiradasilva commented Apr 16, 2016

cyrezdev commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016 • edited

cyrezdev commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016 • edited

andrepereiradasilva commented Apr 17, 2016 • edited

andrepereiradasilva commented Apr 17, 2016 • edited

cyrezdev commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

cyrezdev commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

cyrezdev commented Apr 17, 2016

cyrezdev commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016 • edited

andrepereiradasilva commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

infograf768 commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016 • edited

cyrezdev commented Apr 17, 2016

joomla-cms-bot commented Apr 17, 2016

joomla-cms-bot commented Apr 17, 2016

joomla-cms-bot commented Apr 17, 2016

joomla-cms-bot commented Apr 17, 2016

andrepereiradasilva commented Apr 17, 2016

cyrezdev commented Apr 17, 2016 • edited

andrepereiradasilva commented Apr 17, 2016 • edited

infograf768 commented Apr 18, 2016

infograf768 commented Apr 18, 2016

infograf768 commented Apr 18, 2016

andrepereiradasilva commented Apr 18, 2016

infograf768 commented Apr 18, 2016

cyrezdev commented Apr 18, 2016 • edited

cyrezdev commented Apr 18, 2016 • edited

andrepereiradasilva commented Apr 18, 2016 • edited

cyrezdev commented Apr 18, 2016

cyrezdev commented Apr 19, 2016

cyrezdev commented Apr 15, 2016 •

edited

cyrezdev commented Apr 16, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

cyrezdev commented Apr 17, 2016 •

edited

andrepereiradasilva commented Apr 17, 2016 •

edited

cyrezdev commented Apr 18, 2016 •

edited

cyrezdev commented Apr 18, 2016 •

edited

andrepereiradasilva commented Apr 18, 2016 •

edited