Fix for #9832 + content embedded in a container div #9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Bootstrap modal loads an iframe, BS tooltip with placement top are truncated at the top border of the iframe. (no auto placement in BS2) This PR sets the tooltip placement to bottom. In the same time, content is embedded in a container div (using already existing container-popup class for modal.php)
This was referenced Apr 19, 2016
Closed
cyrezdev
changed the title
|
I have tested this item ✅ successfully on a9c4e02 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991. |
|
I have tested this item ✅ successfully on a9c4e02 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991. |
|
Thanks @andrepereiradasilva and @richard67 for testing 👍 |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9991. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9832 .
Summary of Changes
When Bootstrap modal loads an iframe, BS tooltips with placement top are truncated at the top border of the iframe. (no auto placement in BS2)
This PR sets the tooltip placement to bottom.
In the same time, content is embedded in a container div (using already existing container-popup class for modal.php)
Testing Instructions
Go to: Components > Messaging > click on Settings button to open this modal.
Before Patch:
After Patch:
