Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve mod_multilangstatus z-index problems #9958

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Apr 17, 2016

Pull Request for New Issue.

Summary of Changes

When you have multilanguage status module active the modals are not correctly displayed because the admin status bar as a higher z-index.

image

That z-index is putted there by mod_multilangstatus.

This PR removes that forced z-index.

Testing Instructions

  1. Use latest staging with admin multilanguage status module enabled
  2. Try to do a batch (in article for instance) or any other operation that results in a modal
  3. Check the admin status bar is not darkened like the rest of the page
  4. Apply the patch
  5. Do step 2 again, you will see now the admin status bar it's darkened like the rest of the page

Please notice that this only solves the z-index problems with the status bar. The tooltips not appearing in batch modals are another issue related to mod_multilanguage but not related to z-index.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 8b93dc2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9958.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 8b93dc2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9958.

@MATsxm
Copy link

MATsxm commented Apr 17, 2016

Solved the message display issue 😉

screen shot 2016-04-17 at 14 55 09

screen shot 2016-04-17 at 14 56 05

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9958.

@MATsxm
Copy link

MATsxm commented Apr 17, 2016

I have tested this item ✅ successfully on 8b93dc2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9958.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9958.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2016
@rdeutz rdeutz added this to the Joomla 3.5.2 milestone Apr 18, 2016
@rdeutz rdeutz merged commit cb3ae33 into joomla:staging Apr 18, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 18, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-3 branch April 18, 2016 13:54
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants