Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract nulldate #11396

Merged
merged 3 commits into from Aug 7, 2016
Merged

Abstract nulldate #11396

merged 3 commits into from Aug 7, 2016

Conversation

roland-d
Copy link
Contributor

@roland-d roland-d commented Aug 2, 2016

Summary of Changes

Each database driver has it's own nulldate, we should be checking against that rather than hardcoding a nulldate. This PR fixes the few places where the database driver nulldate is not being used yet.

Testing Instructions

  1. Go to Users and create a new user in the backend
  2. Check that the user appears in the list and the last visit date is showing Never
  3. Apply the patch
  4. Reload the list and the last visit date should still say Never
  5. Go to Content -> Featured Articles
  6. Set the unpublish date for the Beginners article to a date in the past
  7. Login to the front-end as super user
  8. Check the article now contains the div <div class="system-unpublished">
  9. Apply the patch
  10. Check the div <div class="system-unpublished"> is still there
  11. Login to the front-end of the website
  12. Go to Your Profile (this is the user profile page)
  13. Check that the Last visit date is there
  14. Apply the patch
  15. Check that the last visit date is still there
  16. Apply the patch
  17. Check that new users can activate themselves in the User Options
  18. Create a new user on the front-end
  19. Check that the email with the activation link works so that the user is activated
  20. Check that the user is activated
  21. Create a new user in the front-end
  22. In the back-end activate the user as a super user/system administrator
  23. Check that the user is activated

@alikon
Copy link
Contributor

alikon commented Aug 2, 2016

I have tested this item ✅ successfully on 36f8af6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11396.

1 similar comment
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 36f8af6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11396.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11396.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2016
@wilsonge wilsonge merged commit 4c29aaf into joomla:staging Aug 7, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 7, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 7, 2016
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* Clean up null dates

* Fixed a typo
@roland-d roland-d deleted the abstract-nulldate branch January 29, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants