Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Remove not used db reference in users view #37607

Merged
merged 3 commits into from Apr 23, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Apr 22, 2022

Summary of Changes

Removes an obsolete reference in the users back end view. It was used for last visit date from #11396. Since dates are NULL from #26611, the database reference is not used anymore.

Testing Instructions

Go to the site /administrator/index.php?option=com_users&view=users.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

@laoneo laoneo changed the title Remove not used db reference in users view [4.2] Remove not used db reference in users view Apr 22, 2022
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Apr 22, 2022
@toivo
Copy link
Contributor

toivo commented Apr 22, 2022

I have tested this item ✅ successfully on 2d67451

Tested successfully in Joomla 4.2.0-alpha2-dev of 22 April in Wampserver using PHP 8.0.15.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607.

@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

I have tested this item ✅ successfully on 2d67451


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607.

@joomla-cms-bot joomla-cms-bot removed PBF Pizza, Bugs and Fun Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@RickR2H
Copy link
Member

RickR2H commented Apr 22, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607.

@RickR2H RickR2H added RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@richard67 richard67 removed RTC This Pull Request is Ready To Commit PBF Pizza, Bugs and Fun Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 22, 2022
@richard67 richard67 added PBF Pizza, Bugs and Fun Maintainers Checked Used if the PR is conceptional useful labels Apr 22, 2022
@zero-24 zero-24 added this to the Joomla 4.2.0 milestone Apr 23, 2022
@zero-24
Copy link
Contributor

zero-24 commented Apr 23, 2022

Merging thanks :)

@zero-24 zero-24 merged commit d4d4b88 into joomla:4.2-dev Apr 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 23, 2022
@laoneo laoneo deleted the j4/users/view-db branch April 23, 2022 19:43
@richard67 richard67 removed the PBF Pizza, Bugs and Fun label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainers Checked Used if the PR is conceptional useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants