New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Remove not used db reference in users view #37607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
force-pushed
the
j4/users/view-db
branch
from
April 22, 2022 13:07
67cc1cf
to
072b822
Compare
laoneo
changed the title
Remove not used db reference in users view
[4.2] Remove not used db reference in users view
Apr 22, 2022
richard67
approved these changes
Apr 22, 2022
I have tested this item ✅ successfully on 2d67451 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607. |
I have tested this item ✅ successfully on 2d67451 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607. |
joomla-cms-bot
removed
PBF
Pizza, Bugs and Fun
Maintainers Checked
Used if the PR is conceptional useful
labels
Apr 22, 2022
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607. |
RickR2H
added
RTC
This Pull Request is Ready To Commit
PBF
Pizza, Bugs and Fun
Maintainers Checked
Used if the PR is conceptional useful
labels
Apr 22, 2022
richard67
removed
RTC
This Pull Request is Ready To Commit
PBF
Pizza, Bugs and Fun
Maintainers Checked
Used if the PR is conceptional useful
labels
Apr 22, 2022
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37607. |
richard67
added
PBF
Pizza, Bugs and Fun
Maintainers Checked
Used if the PR is conceptional useful
labels
Apr 22, 2022
Merging thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes an obsolete reference in the users back end view. It was used for last visit date from #11396. Since dates are
NULL
from #26611, the database reference is not used anymore.Testing Instructions
Go to the site /administrator/index.php?option=com_users&view=users.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.