Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #11576

Closed
wants to merge 1 commit into from
Closed

Update .travis.yml #11576

wants to merge 1 commit into from

Conversation

csthomas
Copy link
Contributor

Summary of Changes

Load memcachE extension instead memcacheD if memcachE required.

Testing Instructions

???

Load memcachE extension instead memcacheD
@mbabker
Copy link
Contributor

mbabker commented Aug 12, 2016

I'd have to look again but IIRC Memcache isn't something available by
default on Travis.

On Friday, August 12, 2016, Tomasz Narloch notifications@github.com wrote:

Summary of Changes

Load memcachE extension instead memcacheD if memcachE required.
Testing Instructions

???

You can view, comment on, or merge this pull request online at:

#11576
Commit Summary

  • Update .travis.yml

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#11576, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobveSAgAbB-eQVzrqY7w49ycbgZzks5qfPVDgaJpZM4Jjg4Y
.

@@ -68,7 +68,7 @@ before_script:
# Set up Apache
# - ./build/travis/php-apache.sh
# Enable additional PHP extensions
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi
Copy link
Contributor Author

@csthomas csthomas Aug 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before that PR:

  • if I want to install memcachE in travis env why does travis load php memcacheD extension? ???
  • MEMCACHE storage is not tested at all in all php version (except hhvm), but should be tested at least in php 5.6

After that PR: If I want travis to test memcachE then travis loads php memcache.ini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR changed nothing with the Travis test environment, let's not blame
it on anything right now.

If it did indeed cause Memcache to be fatally unusable (it doesn't sound
like that's the case though), pointing out the specific change would be
helpful.

I honestly think we've just got a case of a typo in the test matrix and
needing to validate the config values for Memcahe to work correctly.

On Saturday, August 13, 2016, Tomasz Narloch notifications@github.com
wrote:

In .travis.yml
#11576 (comment):

@@ -68,7 +68,7 @@ before_script:

Set up Apache

- ./build/travis/php-apache.sh

Enable additional PHP extensions

    • if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
    • if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi

Before PR:

  • if I want to install memcachE why does travis load memcacheD? ???
  • MEMCACHE storage is not tested at all in all php version (except
    hhvm), but should be tested at least in php 5.6

After PR: If I want to test memcachE then travis loads memcache.ini


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/11576/files/4937f7cd8d381c37dc9d8bb1899f05d7a1f0b605#r74691928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobfD_SkKHZzr5JHNivRZ-BUb6hcAks5qfisHgaJpZM4Jjg4Y
.

@photodude
Copy link
Contributor

@mbabker

I'd have to look again but IIRC Memcache isn't something available by default on Travis.

memcache should available on travis CI for PHP versions up to 5.6 by default https://blog.travis-ci.com/2013-03-08-preinstalled-php-extensions/

I agree that there is a typo in the build matrix, of course now we need to fix the issues in memcache...

csthomas added a commit to csthomas/joomla-cms that referenced this pull request Aug 18, 2016
…sion

Fix typo.

This is related to joomla#11576. 
IMHO this PR should be applied after PR joomla#11565 will be merged.
@csthomas
Copy link
Contributor Author

This PR is outdated. Go to #11659.

@csthomas csthomas closed this Aug 18, 2016
@csthomas csthomas deleted the patch-1 branch September 22, 2016 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants