Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .travis.yml #11576

Closed
wants to merge 1 commit into from
Closed

Update .travis.yml #11576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ before_script:
# Set up Apache
# - ./build/travis/php-apache.sh
# Enable additional PHP extensions
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi
Copy link
Contributor Author

@csthomas csthomas Aug 13, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before that PR:

  • if I want to install memcachE in travis env why does travis load php memcacheD extension? ???
  • MEMCACHE storage is not tested at all in all php version (except hhvm), but should be tested at least in php 5.6

After that PR: If I want travis to test memcachE then travis loads php memcache.ini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR changed nothing with the Travis test environment, let's not blame
it on anything right now.

If it did indeed cause Memcache to be fatally unusable (it doesn't sound
like that's the case though), pointing out the specific change would be
helpful.

I honestly think we've just got a case of a typo in the test matrix and
needing to validate the config values for Memcahe to work correctly.

On Saturday, August 13, 2016, Tomasz Narloch notifications@github.com
wrote:

In .travis.yml
#11576 (comment):

@@ -68,7 +68,7 @@ before_script:

Set up Apache

- ./build/travis/php-apache.sh

Enable additional PHP extensions

    • if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
    • if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi

Before PR:

  • if I want to install memcachE why does travis load memcacheD? ???
  • MEMCACHE storage is not tested at all in all php version (except
    hhvm), but should be tested at least in php 5.6

After PR: If I want to test memcachE then travis loads memcache.ini

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/11576/files/4937f7cd8d381c37dc9d8bb1899f05d7a1f0b605#r74691928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobfD_SkKHZzr5JHNivRZ-BUb6hcAks5qfisHgaJpZM4Jjg4Y
.

- if [[ $INSTALL_MEMCACHED == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
- if [[ $INSTALL_APC == "yes" ]]; then phpenv config-add build/travis/phpenv/apc-$TRAVIS_PHP_VERSION.ini; fi
- if [[ $INSTALL_APCU == "yes" && $TRAVIS_PHP_VERSION = 5.* ]]; then printf "\n" | pecl install apcu-4.0.10 && phpenv config-add build/travis/phpenv/apcu-$TRAVIS_PHP_VERSION.ini; fi
Expand Down