Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sql azure] Normalize joomla install sample brochure sql file #11793

Merged
merged 3 commits into from
Aug 27, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Aug 25, 2016

Summary of Changes

Normalizes all sql azure joomla sample_brochure.sql install file.

  • always use SET IDENTITY_INSERT [#__xxxx] ON/OFF;
  • INSERT to INSERT INTO
  • Quote all table names and db field names
  • Always use ' to quote string values.
  • solves several problems in the file
  • Code style

Testing Instructions

Mainly code review. (to many changes need to check code in raw)
https://github.com/andrepereiradasilva/joomla-cms/blob/patch-23/installation/sql/sqlazure/sample_brochure.sql

If anyone could test an install of sample brochure 3.6.x would be great. Don't have sql azure to test,

Documentation Changes Required

None.

@waader @alikon please test.

UNION ALL
SELECT 35, 27, 21, 22, 3, 'com_content.article.2', 'About Us', '{}'
UNION ALL
SELECT 36, 8, 26, 33, 2, 'com_content.catery.8', 'News', '{}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is catery should be category

@andrepereiradasilva
Copy link
Contributor Author

solved

@waader
Copy link
Contributor

waader commented Aug 26, 2016

I have tested this item ✅ successfully on 3b8733b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11793.

@alikon
Copy link
Contributor

alikon commented Aug 26, 2016

I have tested this item ✅ successfully on 3b8733b

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11793.

@andrepereiradasilva
Copy link
Contributor Author

can we get a RTC here?

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11793.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 27, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 27, 2016
@rdeutz rdeutz merged commit 9faddcb into joomla:staging Aug 27, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 27, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-23 branch August 27, 2016 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants