Add missing language flags #11868

andrepereiradasilva · 2016-08-31T23:22:27Z

Summary of Changes

Add missing flags.
Language Packs:

German AT (de-AT)
German LI (de-LI)
German LU (de-LU)
German CH (de-CH)
Sinhala (si-LK)

Testing Instructions

Check this images and language packs.

Documentation Changes Required

None.

Bakual · 2016-09-01T06:31:28Z

In Switzerland (de-CH) we usually don't use the Swiss flag to indicate the language. That is because Switzerland has four official languages and thus the flag wouldn't tell you which language it should represent. We usually use the flag from Germany, France and Italy to indicate the languages (the fourth language Romansh is ignored).
Also the flag would have to be a square and not rectangle 😄

So imho at least the Switzerland flag doesn't make any sense to be included. Can't say anything about the other ones.

andrepereiradasilva · 2016-09-01T07:38:16Z

Aldo the ch flag used was the one already in joomla

Bakual · 2016-09-01T07:52:53Z

For each German language pack we should use the de_de.gif, with a different name
de_at.gif, de_li.gif, etc

I'd say for de-AT, the Austrian flag would be appropriate as they only have german as official language. But I don't know what tehy usually use there.

Bakual · 2016-09-01T07:55:52Z

Aldo the ch flag used was the one already in joomla

Yep, technicalls it is a wrong one. But it depends how much one cares :)
Switzerland is one of the very few countries with a square flag.

infograf768 · 2016-09-01T07:59:47Z

The only issue we have with using the same flag for different languages is the impossibility to differentiate them (specially in back-end as in frontend one may decide to use the language tag or name instead of the flags.)

infograf768 · 2016-09-01T08:31:59Z

After more thought, I think this PR is OK.
ch.gif was added to core to let it used if desired and if someone wants to change the content language flags, he can. Therefore using de-DE flag for de-CH, etc.
This is the only solution to have different flags per default for each content language.

infograf768 · 2016-09-01T08:32:28Z

I have tested this item ✅ successfully on 1d0f4b7

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.}

Bakual · 2016-09-01T08:37:07Z

This is the only solution to have different flags per default for each content language.

Currently, it would work because there is no official pack for fr-CH and it-CH. But if someone decides to add those (which for consistency with de-CH should be done) you have de-CH, fr-CH and it-CH all using the Swiss flag by default? Can't be right.
Keep in mind that the de-CH language pack is actually de-DE just with a different language code. It's by no means a Swiss German pack.

infograf768 · 2016-09-01T09:00:33Z

hmm, maybe this then

AnishaTailored · 2016-09-01T09:07:31Z

I have tested this item ✅ successfully on 1d0f4b7

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.}

andrepereiradasilva · 2016-09-01T09:20:39Z

@Bakual i tottaly understand you, that's exactly why flags should not represent languages.
But this is the way Joomla works and allows the user to costumize if they want or don't even show the languages flags in the frontend if they don't want (language swithcer in select list mode).

However is not the intent of this PR to change how Joomla represents content languages.
This PR only intends to correct a bug that when installaing a multilanguage install with those languages the flags for those language packs are missing, thus generating a image not found error.

andrepereiradasilva · 2016-09-01T10:03:53Z

hmm, maybe this then

@Bakual do you agree with this?

Bakual · 2016-09-01T11:29:19Z

I'd prefer something like this:
(stolen from internet as my graphics skills suck)
I saw that a few times being used.

andrepereiradasilva · 2016-09-01T12:43:19Z

@Bakual thanks. please do a PR to this branch or make a new PR with your proposal.

Bakual · 2016-09-01T12:49:53Z

As said my graphic skills aren't good enough to do the image and we can't just steal it from another site for obvious reasons.

infograf768 · 2016-09-01T13:17:54Z

another one:

infograf768 · 2016-09-01T13:22:42Z

Or, see
https://commons.wikimedia.org/wiki/File:Flag_of_Germany_and_Switzerland.png

This is public domain.

MATsxm · 2016-09-01T13:32:26Z

If this can help
http://forum.tsgk.com/viewtopic.php?t=4921

You can see for:
Swiss States and Territories
and German States and Territories

Bakual · 2016-09-01T13:45:05Z

The one from the Wiki looks good to me.

MATsxm · 2016-09-01T13:54:17Z

that means you would use

for en-US ?

Bakual · 2016-09-01T14:18:44Z

I don't know about US but from my understanding the official language in the USA is only english. So the american flag would work there.
Canada would be another example similar to Switzerland because there are two official languages (French and English). But I don't know how "language flags" are handled there.

MATsxm · 2016-09-01T14:23:47Z

Nope.
it is like Swiss 😄
as you have a "french" canadian fr-CA with the canadian flag and then the "french" Québecois (much more restrictive because of their Law 101) with the Flag of Québec

andrepereiradasilva · 2016-09-01T14:24:23Z

en-CA https://github.com/joomla/joomla-cms/blob/staging/media/mod_languages/images/en_ca.gif
fr-CA https://github.com/joomla/joomla-cms/blob/staging/media/mod_languages/images/fr_ca.gif

brianteeman · 2016-09-01T14:26:47Z

Legally the USA does not have an official language :)

MATsxm · 2016-09-01T14:28:16Z

Disagree as some (Acadians for example or part of the region of Nouveau-Brunswick) are speaking also french but are not part of Québec - the flag you are using here https://github.com/joomla/joomla-cms/blob/staging/media/mod_languages/images/fr_ca.gif - and the "french" spoken are not the same.
Free advice, never tell a "Quebecer" he speaks Acadian or even Canadian

andrepereiradasilva · 2016-09-01T14:29:36Z

(seems i opened pandora's box yet again ...)

MATsxm · 2016-09-01T14:30:38Z

Naaa, don't worry... we all know the end already ;)

brianteeman · 2016-09-01T15:15:11Z

Selecting a flag should be the responsibility of the TT. if they choose a specific flag and a user doesn't like it they can change it. It should not be the role of core to make a decision on the flag to use.

andrepereiradasilva · 2016-09-01T15:18:19Z

ok, so please someone ask the creators of the following language packages for a 18x12 gif image for each of this language packs.

German AT (de-AT)
German LI (de-LI)
German LU (de-LU)
German CH (de-CH)

Can anyone do that?

Bakual · 2016-09-01T15:29:42Z

Can anyone do that?

Pinging @sisko1990 as he is the creator of all those packs (imho, they are identical anyway).

jsubri · 2016-09-01T19:38:56Z

If we apply the logic of the flags presented here, the de_ch.gif, fr_ch.gif and it_ch.gif should be identical but do not represent languages.
Swiss French speaks french, while the Swiss German are speaking "Schweizerdeutsch" while educated in Hochdeutsch (german) and Swiss Italian are speaking italian. From a Joomla translation packs perspective, Swiss German are using the DE pack, Swiss French are using the FR pack and the IT pack for the Swiss Italian. So the translation packs are respectively DE, FR and IT and no official xx-CH flags exists!

Now if the translation teams have a specific flag for ca-ES "Catalan" they should be free to display an alternative flag for that.

infograf768 · 2016-09-02T06:17:35Z

@jsubri
We DO need different "flags" for each content language to differentiate them in the UI, specially in back-end.
The other reason should be simple to understand: a user may decide to make a multilang site which targets various specific language-speaking regions/countries (German in this example), for example a e-commerce site where prices are in Euros for Germany and Swiss Francs in Switzerland, so he will use a content language for each region/countries.

brianteeman · 2016-09-02T07:42:03Z

We dont need flags to differentiate the languages in the UI if we stop
incorrectly using flags to differentiate languages in the admin

On 2 September 2016 at 07:17, infograf768 notifications@github.com wrote:

@jsubri https://github.com/jsubri
We DO need different "flags" for each content language to differentiate
them in the UI, specially in back-end.
The other reason should be simple to understand: a user may decide to make
a multilang site which targets various specific language-speaking
regions/countries (German in this example), for example a e-commerce site
where prices are in Euros for Germany and Swiss Francs in Switzerland, so
he will use a content language for each region/countries.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11868 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b4mP0YilPeDYkfnh4FpAUqsJo-0ks5ql7-CgaJpZM4JyKkf
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

jsubri · 2016-09-02T08:15:33Z

Yes, I understand the need of it.
Problem statement: the country flag alone may not represent the language content.

IMHO getting the creation of 3 flags that slightly distinguish the language for CH-DE, CH-FR and CH-IT such as would be a good indicator of the regional flavor(s).
This would resolve the ugly mixture of multiple country flags.

tomartailored · 2016-09-02T09:05:34Z

I have tested this item ✅ successfully on 1d0f4b7

i have tested this item succesfully

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11868.}

Bakual · 2016-09-02T18:39:03Z

Merged the PR and changed the Swiss German flag with an own commit (d114493)

add missing flags

1d0f4b7

joomla-cms-bot added the PR-staging label Aug 31, 2016

andrepereiradasilva changed the title ~~Add missing flags~~ Add missing language flags Aug 31, 2016

andrepereiradasilva mentioned this pull request Sep 1, 2016

Add Unpublished Content Language on Language Package Install #11867

Merged

Bakual added this to the Joomla 3.6.3 milestone Sep 2, 2016

Bakual merged commit 97461d7 into joomla:staging Sep 2, 2016

andrepereiradasilva deleted the missing_flags branch September 2, 2016 18:37

Bakual mentioned this pull request Sep 12, 2016

[4.0] Flags are country flags, not language flags #12014

Closed

Bakual mentioned this pull request Apr 4, 2020

[4.0] Flags are country flags, not language flags #28575

Closed

Add missing language flags #11868

Add missing language flags #11868

Conversation

andrepereiradasilva commented Aug 31, 2016 • edited by joomla-cms-bot Loading

Summary of Changes

Testing Instructions

Documentation Changes Required

Bakual commented Sep 1, 2016

andrepereiradasilva commented Sep 1, 2016

Bakual commented Sep 1, 2016

Bakual commented Sep 1, 2016

infograf768 commented Sep 1, 2016 • edited Loading

infograf768 commented Sep 1, 2016

infograf768 commented Sep 1, 2016

Bakual commented Sep 1, 2016

infograf768 commented Sep 1, 2016

AnishaTailored commented Sep 1, 2016

andrepereiradasilva commented Sep 1, 2016 • edited Loading

andrepereiradasilva commented Sep 1, 2016

Bakual commented Sep 1, 2016

andrepereiradasilva commented Sep 1, 2016

Bakual commented Sep 1, 2016

infograf768 commented Sep 1, 2016

infograf768 commented Sep 1, 2016 • edited Loading

MATsxm commented Sep 1, 2016

Bakual commented Sep 1, 2016

MATsxm commented Sep 1, 2016

Bakual commented Sep 1, 2016

MATsxm commented Sep 1, 2016

andrepereiradasilva commented Sep 1, 2016

brianteeman commented Sep 1, 2016 via email

MATsxm commented Sep 1, 2016 • edited Loading

andrepereiradasilva commented Sep 1, 2016

MATsxm commented Sep 1, 2016

brianteeman commented Sep 1, 2016 via email

andrepereiradasilva commented Sep 1, 2016

Bakual commented Sep 1, 2016

jsubri commented Sep 1, 2016 • edited Loading

infograf768 commented Sep 2, 2016

brianteeman commented Sep 2, 2016

jsubri commented Sep 2, 2016

tomartailored commented Sep 2, 2016

Bakual commented Sep 2, 2016

andrepereiradasilva commented Aug 31, 2016 •

edited by joomla-cms-bot

Loading

infograf768 commented Sep 1, 2016 •

edited

Loading

andrepereiradasilva commented Sep 1, 2016 •

edited

Loading

infograf768 commented Sep 1, 2016 •

edited

Loading

MATsxm commented Sep 1, 2016 •

edited

Loading

jsubri commented Sep 1, 2016 •

edited

Loading