Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Fix unit test: Now is assertTrue not assertNull #12433

Merged
merged 2 commits into from
Oct 16, 2016
Merged

[4.0] Fix unit test: Now is assertTrue not assertNull #12433

merged 2 commits into from
Oct 16, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

Summary of Changes

Correct unit test in 4.0 after #12432 merge

Testing Instructions

Unit test pass.

Documentation Changes Required

None.

@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 16, 2016
@zero-24
Copy link
Contributor

zero-24 commented Oct 16, 2016 

1) JDocumentHtmlTest::testTheDefaultReturnForIsHtml5
Failed asserting that true is null.
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/joomla/document/html/JDocumentHTMLTest.php:166
2) JDocumentHtmlTest::testTheDefaultReturnForSetHtml5
Failed asserting that null is true.

https://travis-ci.org/joomla/joomla-cms/jobs/168054439

@zero-24 zero-24 merged commit a416bcc into joomla:4.0-dev Oct 16, 2016
@zero-24
Copy link
Contributor

zero-24 commented Oct 16, 2016

Merged.

@andrepereiradasilva andrepereiradasilva deleted the patch-20 branch October 16, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Unit/System Tests
Projects
None yet
Milestone
Joomla 4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepereiradasilva @zero-24 @joomla-cms-bot