Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax list limit issue in menu manager edit form #12510

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

izharaazmi
Copy link
Contributor

@izharaazmi izharaazmi commented Oct 22, 2016

Summary of Changes

When creating/editing a menu item, the list of available choices for parent menu item is populated via ajax whenever the "menu" option is changed.

Currently this list is limited to 20, which should not apply here and all the items in the selected menu must be shown.

Testing Instructions

  1. Create more than 20 menu items under a single menu (let's say Main Menu).
  2. Go to create another menu item under User Menu and before you hit save change the Menu selection to Main Menu
  3. Notice the Parent Menu dropdown just below the Menu field, it will show only the first 20 menu items from Main Menu
  4. Apply this patch, and repeat 2 and 3. It should now show all the available menu items.

Documentation Changes Required

None

The list limit of default 20 was being forced on ajax request for parent items in menu edit form. Now this should load all items.
@izharaazmi
Copy link
Contributor Author

izharaazmi commented Oct 22, 2016

I think there is a translation issue too. I'll look at that later in a different PR. Time's up for today!

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 99158ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12510.

@coolcat-creations
Copy link
Contributor

I have tested this item ✅ successfully on 99158ca

:y:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12510.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12510.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 16, 2016
@brianteeman brianteeman added this to the Joomla 3.7.0 milestone Nov 24, 2016
@rdeutz rdeutz merged commit 9aa272f into joomla:staging Dec 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 6, 2016
@izharaazmi izharaazmi deleted the patch-4 branch December 7, 2016 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants