Don't skip JHtml's bootstrap call for ovewrite check #12854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The JHtml class allows to override all calls which are made over the JHtml::_ method. That means, you can inject your own functions via plugin into this class to implement an alternative for the core implemention.
So now everytime somewhere in Joomla! JHtml::_('bootstrap.framework'); is called, this alternative function is used. So far so good.
But if you now use a default bootstrap method like
JHtml::_('bootstrap.tooltip');
the method "tooltip" does not use the ovewriten function from above but the default bootstrap.framework method.This patch fixs this problem by calling always the correct function/method
Testing Instructions
Normaly the "clean" way is to create an plugin and implement the register stuff for JHtml there. For testing purpose a quick way would be to open components/com_content/content.php and add in line 11 the following code:
Now just open an article in the frontend.
Result
Before patch: default bootstrap stuff is loaded
After patch: site shows "new function called"